Repository navigation
[3.15] gh-160268: Fix tokenize on a mismatched closing bracket in an f-string (GH-160272) - #160335
Merged
Merged
Conversation
…in an f-string (pythonGH-160272) Since pythongh-105042, `tokenize` tolerates mismatched brackets. That also let a mismatched closing bracket pop the brace that opened an f-string replacement field, which the f-string state relies on. In `f'{]a'`, this triggered an assertion failure in _PyLexer_scan_string. Check the replacement field brace in both modes. (cherry picked from commit 86758d1) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gh-105042,
tokenizetolerates mismatched brackets. That also let a mismatched closing bracket pop the brace that opened an f-string replacement field, which the f-string state relies on. Inf'{]a', this triggered an assertion failure in _PyLexer_scan_string.Check the replacement field brace in both modes.
(cherry picked from commit 86758d1)
tokenizecrashes on a mismatched closing bracket in an f-string replacement field #160268