Repository navigation
gh-124948: Reject explicit Cortex-A53 workaround flags with BOLT - #160337
Merged
Merged
Conversation
Documentation build overview
|
corona10
changed the title
zanieb
marked this pull request as ready for review
October 22, 2026 21:37
zanieb
requested review from
AA-Turner,
emmatyping,
erlend-aasland and
itamaro
as code owners
October 22, 2026 21:37
itamaro
approved these changes
Oct 22, 2026
itamaro
left a comment
itamaro
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but why skip issue?
corona10
enabled auto-merge (squash)
October 22, 2026 21:50
Member
|
@itamaro I think that user (who build CPython) should know the change, because it will affects all ARM users if the distribution pass the specific flag. |
Member
Oh I thought that skip news lol |
Contributor
|
does this need backports? |
Contributor
Author
|
Sorry why did we link this to #124948 ? That doesn't seem right? |
Contributor
Author
|
I skipped the issue because this is just an informational convenience, BOLT will already fail if you are using this flag, this just makes the error a bit friendly in CPython's build system. |
Contributor
Author
|
I don't think this needs backport, since it's not fixing a bug as described above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent BOLT versions reject AArch64 binaries containing Cortex-A53 erratum 843419 workaround veneers by default. Report an earlier error from
configure --enable-boltwhen build flags explicitly request the workaround. The check only inspects explicit flags because recent BOLT already diagnoses veneers produced by compiler defaults.Document that BOLT output must not run on affected processors and how to override GCC's default workaround with
LDFLAGS_NODIST="-mno-fix-cortex-a53-843419"for builds confined to unaffected hardware. Explicit enabling flags must be removed separately.