Repository navigation
Conversation
…it in tarfile and zipfile When extracting a regular file, open the output with O_CREAT|O_EXCL and, if something already exists at the path, unlink it and retry once, instead of opening with O_TRUNC. Previously an existing symlink or hardlink at that path was written through, which could modify a file outside the extraction directory, also under tarfile's 'data' and 'tar' filters. Windows and Emscripten follow a dangling symlink even with O_EXCL, so there the path is unlinked before opening. The helper lives in a new private module, _archive, shared by tarfile and zipfile. Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
tarfile-replace-links
branch
from
October 23, 2026 17:22
8eafb15 to
460e7e9
Compare
Contributor
Author
|
Possibly of interest to @woodruffw. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting a regular file, open the output with O_CREAT|O_EXCL and, if something already exists at the path, unlink it and retry once, instead of opening with O_TRUNC. Previously an existing symlink or hardlink at that path was written through, which could modify a file outside the extraction directory, also under tarfile's 'data' and 'tar' filters.
Windows and Emscripten follow a dangling symlink even with O_EXCL, so there the path is unlinked before opening.
The helper lives in a new private module, _archive, shared by tarfile and zipfile.