Repository navigation
[3.14] gh-160299: Preserve references from inlined comprehensions (GH-160413) - #160457
Merged
Merged
Conversation
…ns (pythonGH-160413) Adapt the reference-flag propagation from pythonGH-156819 to fix pythongh-160299 without backporting the comprehensive changes to comprehension scope representation and compilation. (cherry picked from commit cc3a0c9)
carljm
added
type-bug
iritkatriel
approved these changes
Oct 23, 2026
carljm
marked this pull request as ready for review
October 23, 2026 18:12
carljm
enabled auto-merge (squash)
October 23, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #160413 to Python 3.14, fixing #160299: local and nonlocal names in function scopes are now marked as referenced when their only uses are in inlined comprehensions.
The more comprehensive fix in #156819 is not backportable because it changes comprehension scope representation and compilation. This backports the same narrow reference-flag fix as #160413, preserving 3.14's existing symbol-table structure.
(cherry picked from commit cc3a0c9)