Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions mypy/semanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -1878,7 +1878,7 @@ def push_type_args(
return None
tvs.append((p.name, tv))

if self.is_defined_type_param(p.name):
if self.get_defined_type_param(p.name):
self.fail(f'"{p.name}" already defined as a type parameter', context)
else:
assert self.add_symbol(
Expand All @@ -1887,15 +1887,13 @@ def push_type_args(

return tvs

def is_defined_type_param(self, name: str) -> bool:
for names in self.locals:
if names is None:
continue
if name in names:
def get_defined_type_param(self, name: str) -> TypeVarLikeExpr | None:
for names in reversed(self.locals):
if names is not None and name in names:
node = names[name].node
if isinstance(node, TypeVarLikeExpr):
return True
return False
return node
return None

def analyze_type_param(
self, type_param: TypeParam, context: Context
Expand Down Expand Up @@ -2343,15 +2341,15 @@ class Foo(Bar, Generic[T]): ...
has_type_var_tuple = False
if defn.type_args is not None:
for p in defn.type_args:
node = self.lookup(p.name, context)
node = self.get_defined_type_param(p.name)
assert node is not None
assert isinstance(node.node, TypeVarLikeExpr)
if isinstance(node.node, TypeVarTupleExpr):
assert isinstance(node, TypeVarLikeExpr)
if isinstance(node, TypeVarTupleExpr):
if has_type_var_tuple:
self.fail("Can only use one type var tuple in a class def", context)
continue
has_type_var_tuple = True
declared_tvars.append((p.name, node.node))
declared_tvars.append((p.name, node))

for i, base_expr in enumerate(base_type_exprs):
if isinstance(base_expr, StarExpr):
Expand Down
7 changes: 7 additions & 0 deletions test-data/unit/check-python312.test
Original file line number Diff line number Diff line change
Expand Up @@ -2296,6 +2296,13 @@ class D[*Ts](Generic[Unpack[Us]]): # E: Generic[...] base class is redundant \
pass
[builtins fixtures/tuple.pyi]

[case testPEP695TypeVarReusedName]
class C:
X = 5
class Inner[X]:
pass
[builtins fixtures/tuple.pyi]

[case testPEP695VariadicAliasUnpack]
class C[*Ts]:
pass
Expand Down
Loading