[mypyc] Use shared value for Final attribute initialized in class body - #21932
Merged
Conversation
Don't make it into an instance attribute. Don't run the initializer more than once.
p-sawicki
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a module-level static for Final attributes initialized in class body:
Previously such final attributes where stored in the per-instance struct, and a new object was allocated for each instance, which deviated from Python semantics and was inefficient. Now the initializer is only run once.
Final attributes that have a type with an overlapping error value like
i64are still not supported properly. This is left as follow-up work.I used coding agent assist but reviewed the result manually and iterated on it.