Repository navigation
[mypyc] Borrow generator frame state more aggressively - #21987
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
p-sawicki
approved these changes
Sep 15, 2026
| ) -> None: | ||
| self.self_reg = self_reg | ||
| self.candidates = candidates | ||
| self.candidates_by_attr = candidates_by_attr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame is private, and the generator running flag prevents another helper invocation from accessing it concurrently, so attribute values can be borrowed while the helper runs. This is particularly helpful on free-threaded builds, since reference counting is expensive.
I checked that this speeds up some microbenchmarks, from 1.04x to 1.8x on Python 3.14.
I used coding agent assist but did many iterative improvements.