Repository navigation
[mypyc] Fix name conflict when creating CPyFunction variable - #21992
Merged
JukkaL merged 2 commits intoSep 15, 2026
Merged
Conversation
JukkaL
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local variables for
CPyFunctionobjects are named by taking the C name of the wrapped function and adding_wrapperat the end. This creates a name conflict when a class has two async methods with names X and X_wrapper and means that theCPyFunctionvariable shadows the function definition.The function name is used as a function pointer and passing the
CPyFunctionobject instead causes a segfault.Fix by naming the variables by using a prefix instead. The C function names are already prefixed by
CPyPy_and the class name so there shouldn't be conflicts through Python names.