Repository navigation
split out pre-commit from test-requirements to lighten CI load - #21999
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
especially on systems like riscv64 that don't have wheels available for the pyyaml dependency of pre-commit
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
Author
|
@ilevkivskyi Can this be merged? |
Member
|
OK, if there are no objections from @JukkaL I will merge this tomorrow. |
Member
|
I didn't hear any objections, so merging this as promised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
especially on systems like riscv64 that don't have wheels available for the pyyaml dependency of pre-commit
Developers are now instructed to
pip install -r dev-requirements.txtinstead oftest-requirements.txtNote: I re-generated
test-requirements.txtusing Python 3.10 and I didn't find instructions on how you all prefer to regenerate that file