Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions mypy/semanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,7 @@ def analyze_class(self, defn: ClassDef) -> None:
self.defer(force_progress=tvar_defs != defn.type_vars)

self.analyze_class_keywords(defn)
bases_result = self.analyze_base_classes(defn.name, bases)
bases_result = self.analyze_base_classes(defn, bases)
if bases_result is None or self.found_incomplete_ref(tag):
# Something was incomplete. Defer current target.
self.mark_incomplete(defn.name, defn)
Expand Down Expand Up @@ -2621,7 +2621,7 @@ def get_name_repr_of_expr(self, expr: Expression) -> str | None:
return None

def analyze_base_classes(
self, cls_name: str, base_type_exprs: list[Expression]
self, defn: ClassDef, base_type_exprs: list[Expression]
) -> tuple[list[tuple[ProperType, Expression]], bool] | None:
"""Analyze base class types.

Expand All @@ -2634,6 +2634,16 @@ def analyze_base_classes(
is_error = False
bases = []
for i, base_expr in enumerate(base_type_exprs):
if (
isinstance(base_expr, RefExpr)
and self.type is not None
and base_expr.node is self.type
and defn in self.type.defn.defs.body
):
# The enclosing class isn't bound until its body has finished executing.
self.name_not_defined(self.type.name, base_expr)
is_error = True
continue
if (
isinstance(base_expr, RefExpr)
and base_expr.fullname in TYPED_NAMEDTUPLE_NAMES + TPDICT_NAMES
Expand All @@ -2654,7 +2664,7 @@ def analyze_base_classes(
base_expr,
allow_placeholder=True,
allow_type_any=True,
unique_name=inline_base(cls_name, i),
unique_name=inline_base(defn.name, i),
)
except TypeTranslationError:
name = self.get_name_repr_of_expr(base_expr)
Expand Down
8 changes: 8 additions & 0 deletions test-data/unit/check-classes.test
Original file line number Diff line number Diff line change
Expand Up @@ -8599,6 +8599,14 @@ class B(A): # E: Final class __main__.B has abstract attributes "foo"
class C:
class C1(XX): pass # E: Name "XX" is not defined

[case testOuterClassAsNestedClassBase]
class Outer:
class Invalid(Outer): pass # E: Name "Outer" is not defined

class Base: pass
class OtherOuter:
class Valid(Base): pass

[case testArgsKwargsInheritance]
from typing import Any

Expand Down
Loading