Repository navigation
[mypyc] Fix segfault when importing package with module-level __getattr__ - #22205
Merged
Merged
Conversation
…attr__ Fixes mypyc/mypyc#1198. Importing a compiled package that defines a module-level `__getattr__` could segfault: ```python # pkg/__init__.py def __getattr__(name: str) -> object: raise AttributeError(name) ``` When initializing a module, mypyc checks whether `__file__`, `__path__` and other module attributes are already set using `getattr`, and this calls the module `__getattr__` if the attribute is not found. Since module-level functions are available before the module body has been executed, this calls compiled code before the module has been fully initialized. Now these attributes are looked up directly from the module dict, so that `__getattr__` is not called.
p-sawicki
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1198.
Importing a compiled package that defines a module-level
__getattr__could segfault:When initializing a module, mypyc checks whether
__file__,__path__and other module attributes are already set usinggetattr, and this calls the module__getattr__if the attribute is not found. Since module-level functions are available before the module body has been executed, this calls compiled code before the module has been fully initialized.Now these attributes are looked up directly from the module dict, so that
__getattr__is not called.