Repository navigation
[mypyc] Fix crash and reference leaks on base resolution failures - #22244
Merged
p-sawicki merged 2 commits intoOct 21, 2026
Merged
Conversation
JukkaL
approved these changes
Oct 21, 2026
| assert read_numbers(child, 100) == 300.0 | ||
|
|
||
|
|
||
| [case testNativeClassDocAfterFailedConstruction] |
Collaborator
There was a problem hiding this comment.
Can you merge these into an existing [case ...] since each run test has a substantial per-test case overhead? Possible rename a test if you can't find an existing one that would cover these test cases cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_basesreturnsNULLon error but the result was not checked so the null pointer could be passed to a function that doesn't expect it and crash.Add a null check and missing decrefs in
update_baseson failures.When creating a type object from a template, the
tp_docpointer was allocated twice, so keep just one allocation.