Repository navigation
[mypyc] Fix reference leaks of temporaries in singledispatch registration - #22245
Merged
p-sawicki merged 1 commit intoOct 21, 2026
Merged
Conversation
JukkaL
approved these changes
Oct 21, 2026
| [file driver.py] | ||
| import register | ||
|
|
||
| [case testRegisterAnnotationErrorOwnership] |
Collaborator
There was a problem hiding this comment.
Run tests are quite expensive run each, and singledispatch is a pretty rarely used feature. Can you merge some of these tests in a follow-up PR so that each [case ...] has multiple test_* functions, as this will be more efficient? (No need to merge everything into one case, but more like reduce the number of distinct cases by a decent number where they are easy to merge.)
Collaborator
Author
There was a problem hiding this comment.
ok will prepare a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release temporary objects created in the register function both on success and failure. Add null checks to fix crash when type hints are not available.