Repository navigation
Fix false positive on generic NamedTuple __new__ - #22258
Merged
Merged
Conversation
Use erased named-tuple items when filling type variables with Any fill_typevars_with_any computes an erased tuple but copies the original items back into its result. Keep the erased items so they agree with the Any-parameterized fallback, and remove the caller's compensating erasure. This also prevents false __new__ return-type errors for generic named-tuple subclasses. Extend the constructor test to accept a concrete specialization while still rejecting a return type outside the subclass. Authored by Codex
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
- sphinx/testing/util.py:80:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
scipy-stubs (https://github.com/scipy/scipy-stubs)
+ scipy-stubs/_lib/_ccallback.pyi:123: error: Unused "type: ignore" comment [unused-ignore]
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
hauntsaninja
marked this pull request as ready for review
October 21, 2026 19:22
Collaborator
Author
|
Great, scipy-stubs unused ignore is correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use erased named-tuple items when filling type variables with Any
fill_typevars_with_any computes an erased tuple but copies the original items back into its result. Keep the erased items so they agree with the Any-parameterized fallback, and remove the caller's compensating erasure.
This also prevents false new return-type errors for generic named-tuple subclasses. Extend the constructor test to accept a concrete specialization while still rejecting a return type outside the subclass.
Authored by Codex