Repository navigation
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Oct 29, 2026
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks! I will try to look in more details in next few days.
Also cc @hauntsaninja in case you would prefer to incorporate this into mypy_primer instead.
| [env] | ||
| CC = "clang" | ||
| MYPYC_OPT_LEVEL = "0" | ||
| MYPYC_DEBUG_LEVEL = "0" |
Member
There was a problem hiding this comment.
Not sure about this. Should we set this to 2 (or whatever is the equivalent of -g)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI validation similar to mypy primer for mypyc changes. The new job compiles and tests configured projects in PRs that change mypyc. Initially configure
blackas there have been regressions in mypyc in the past that broke it.The
mypyc_primerscript clones the project, sets it up and builds it according to configuration using mypyc pinned athead_sha(PR commit in CI), and runs configured tests. If any step fails, the run is repeated but this time using mypyc pinned atbase_sha(target branch commit in CI) so failures introduced by the mypyc change can be distinguished from a broken upstream project or infra issues.Once results for all projects are ready another CI job posts a comment in the PR either with a success message or a list of failures with links to logs. Example comments are in my fork: success and failure. If the job is skipped because mypyc is not changed in the PR the comment job is skipped as well - example.
The
mypyc_primerscript can also be used to validate changes locally. Instructions for this are in the comment at the top of the script.