Skip to content

[kafka-python] Add missing __slots__ #16218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Aug 16, 2026
Merged

[kafka-python] Add missing __slots__ #16218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions stubs/kafka-python/kafka/record/default_records.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ from _typeshed import Incomplete
from kafka.record.abc import ABCRecord, ABCRecordBatch, ABCRecordBatchBuilder

class DefaultRecordBase:
__slots__ = ()
HEADER_STRUCT: Incomplete
ATTRIBUTES_OFFSET: Incomplete
CRC_OFFSET: Incomplete
Expand All @@ -23,6 +24,7 @@ class DefaultRecordBase:
MAX_INT: int

class DefaultRecordBatch(DefaultRecordBase, ABCRecordBatch):
__slots__ = ("_buffer", "_header_data", "_pos", "_num_records", "_next_record_index", "_decompressed")
def __init__(self, buffer) -> None: ...
@property
def base_offset(self): ...
Expand Down Expand Up @@ -73,6 +75,7 @@ class DefaultRecordBatch(DefaultRecordBase, ABCRecordBatch):
def validate_crc(self): ...

class DefaultRecord(ABCRecord):
__slots__ = ("_size_in_bytes", "_offset", "_timestamp", "_timestamp_type", "_key", "_value", "_headers")
def __init__(self, size_in_bytes, offset, timestamp, timestamp_type, key, value, headers) -> None: ...
@property
def size_in_bytes(self): ...
Expand All @@ -93,6 +96,7 @@ class DefaultRecord(ABCRecord):
def validate_crc(self): ...

class ControlRecord(DefaultRecord):
__slots__ = ("_size_in_bytes", "_offset", "_timestamp", "_timestamp_type", "_key", "_value", "_headers", "_version", "_type")
KEY_STRUCT: Incomplete
def __init__(self, size_in_bytes, offset, timestamp, timestamp_type, key, value, headers) -> None: ...
@property
Expand All @@ -105,6 +109,20 @@ class ControlRecord(DefaultRecord):
def commit(self): ...

class DefaultRecordBatchBuilder(DefaultRecordBase, ABCRecordBatchBuilder):
__slots__ = (
"_magic",
"_compression_type",
"_batch_size",
"_is_transactional",
"_producer_id",
"_producer_epoch",
"_base_sequence",
"_first_timestamp",
"_max_timestamp",
"_last_offset",
"_num_records",
"_buffer",
)
MAX_RECORD_OVERHEAD: int
def __init__(
self, magic, compression_type, is_transactional, producer_id, producer_epoch, base_sequence, batch_size
Expand Down Expand Up @@ -146,6 +164,7 @@ class DefaultRecordBatchBuilder(DefaultRecordBase, ABCRecordBatchBuilder):
def estimate_size_in_bytes(cls, key, value, headers): ...

class DefaultRecordMetadata:
__slots__ = ("_size", "_timestamp", "_offset")
def __init__(self, offset, size, timestamp) -> None: ...
@property
def offset(self): ...
Expand Down