Skip to content

Disallow False to be passed to LogRecord(exc_info) #16541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srittau wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disallow False to be passed to LogRecord(exc_info) #16541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7303fd
Fix LogRecord.__init__
srittau Oct 16, 2026
8724ad2
Update comments
srittau Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions stdlib/logging/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,14 @@ class Filter:
def filter(self, record: LogRecord) -> bool: ...

class LogRecord:
# args can be set to None by logging.handlers.QueueHandler
# (see https://bugs.python.org/issue44473)
# args can be set to None by logging.handlers.QueueHandler, which
# contradicts the LogRecord documentation, but seems to be intentional,
# see https://github.com/python/cpython/issues/88639
args: _ArgsType | None
asctime: str
created: float
# Logger._log() only normalizes truthy exc_info values so
# exc_info=False ends up on the record unchanged.
# Prior to Python 3.16, Logger._log() only normalizes truthy exc_info
# values so exc_info=False ends up on the record unchanged.
exc_info: _SysExcInfoType | Literal[False] | None
exc_text: str | None
filename: str
Expand Down Expand Up @@ -344,8 +345,11 @@ class LogRecord:
pathname: str,
lineno: int,
msg: object,
# args can be set to None by logging.handlers.QueueHandler, which
# contradicts the LogRecord documentation, but seems to be intentional,
# see https://github.com/python/cpython/issues/88639
args: _ArgsType | None,
exc_info: _SysExcInfoType | Literal[False] | None,
exc_info: _SysExcInfoType | None,
func: str | None = None,
sinfo: str | None = None,
) -> None: ...
Expand Down
Loading