Skip to content

Arm backend: Xfail RIFE VGF tests with lazy import (#21786) - #21786

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:revert-21755-bardem01/rife-vgf-reshape-investigation
Open

Arm backend: Xfail RIFE VGF tests with lazy import (#21786)#21786
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:revert-21755-bardem01/rife-vgf-reshape-investigation

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary:
Reapplies #21755 after the revert in #21783, but imports the model-converter version helpers lazily during test collection. This avoids importing torch from the Arm conftest before internal test infrastructure has initialized its symbols, while preserving the RIFE VGF quant test xfail behavior.

The import is attempted only when matching RIFE VGF quant tests are collected.

Test Plan:
CI

cc digantdesai freddan80 per zingo oscarandersson8218 mansnils Sebastian-Larsson robell rascani

Reviewed By: digantdesai

Differential Revision: D115750356

Pulled By: JakeStevens

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21786

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit f724276 with merge base e265ea6 (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / test-arduino-library / run / arduino-library (gh)
    RuntimeError: Command docker exec -t 6ff0ca6c7a1ed00ca2676f60b489fc0332f664c54cb8452138b073d19b97e60d /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 12, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JakeStevens
JakeStevens force-pushed the revert-21755-bardem01/rife-vgf-reshape-investigation branch from a9b5f6e to aa00783 Compare August 12, 2026 18:11
@meta-codesync

meta-codesync Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has imported this pull request. If you are a Meta employee, you can view this in D115750356.

@JakeStevens
JakeStevens requested review from rascani and zingo August 12, 2026 19:12

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Summary:
Reapplies pytorch#21755 after the revert in pytorch#21783, but imports the model-converter version helpers lazily during test collection. This avoids importing torch from the Arm conftest before internal test infrastructure has initialized its symbols, while preserving the RIFE VGF quant test xfail behavior.

The import is attempted only when matching RIFE VGF quant tests are collected.


Test Plan:
CI

cc digantdesai freddan80 per zingo oscarandersson8218 mansnils Sebastian-Larsson robell rascani

Reviewed By: digantdesai

Differential Revision: D115750356

Pulled By: JakeStevens
@meta-codesync meta-codesync Bot changed the title Arm backend: Xfail RIFE VGF tests with lazy import Arm backend: Xfail RIFE VGF tests with lazy import (#21786) Aug 13, 2026
@JakeStevens
JakeStevens force-pushed the revert-21755-bardem01/rife-vgf-reshape-investigation branch from 0fe10ac to f724276 Compare August 13, 2026 14:59
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115750356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants