Arm backend: Xfail RIFE VGF tests with lazy import (#21786) - #21786
Arm backend: Xfail RIFE VGF tests with lazy import (#21786)#21786JakeStevens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit f724276 with merge base e265ea6 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
a9b5f6e to
aa00783
Compare
|
@JakeStevens has imported this pull request. If you are a Meta employee, you can view this in D115750356. |
digantdesai
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Reapplies pytorch#21755 after the revert in pytorch#21783, but imports the model-converter version helpers lazily during test collection. This avoids importing torch from the Arm conftest before internal test infrastructure has initialized its symbols, while preserving the RIFE VGF quant test xfail behavior. The import is attempted only when matching RIFE VGF quant tests are collected. Test Plan: CI cc digantdesai freddan80 per zingo oscarandersson8218 mansnils Sebastian-Larsson robell rascani Reviewed By: digantdesai Differential Revision: D115750356 Pulled By: JakeStevens
0fe10ac to
f724276
Compare
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115750356. |
Summary:
Reapplies #21755 after the revert in #21783, but imports the model-converter version helpers lazily during test collection. This avoids importing torch from the Arm conftest before internal test infrastructure has initialized its symbols, while preserving the RIFE VGF quant test xfail behavior.
The import is attempted only when matching RIFE VGF quant tests are collected.
Test Plan:
CI
cc digantdesai freddan80 per zingo oscarandersson8218 mansnils Sebastian-Larsson robell rascani
Reviewed By: digantdesai
Differential Revision: D115750356
Pulled By: JakeStevens
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani