Clean up executorch type checking setup (#21719) - #21793
Open
maggiemoss wants to merge 1 commit into
Open
Conversation
Summary: `fbcode/executorch/PACKAGE` carried a `python.set_pyrefly(False)` opt-out. Remove it so executorch inherits `python.set_pyrefly(True)` from the fbcode root. Removing the opt-out on its own would have flipped 43 targets from classic Pyre onto Pyrefly and surfaced real type errors (nullability on `mem_id` / `mem_offset` in `test_memory_passes.py`, `tuple[SourcePartition, ...]` vs `list[GraphModule]` in `quantizer.py`, a missing `PassResult` return, and others). Every one of those targets is in open-source code. executorch syncs to the open-source `pytorch/executorch` repo, which is why the root already sets `python.set_typing(False)` — suppressions added here leak into OSS and break OSS CI on checker upgrades. That policy was being undercut by 43 target-level `typing = True` attributes outside the internal `fb/` subtrees, and those overrides were the *only* thing pulling OSS files into type checking. So rather than write Pyrefly suppressions into OSS-synced files, drop the overrides and let the package-level `set_typing(False)` stand. Internal `fb/` code is untouched: the 66 typed targets under `examples/models/fb/` were already on Pyrefly via `examples/models/fb/PACKAGE` and stay type-checked, now by inheritance from the fbcode root. Note for reviewers: `backends/cadence` loses the Pyre coverage it had. That is the intended trade — it is OSS-synced, and its errors cannot be suppressed in-tree without leaking into the public repo — but it is a coverage reduction that should be an explicit owner decision, not an auto-accept. The `typing_stubs` target in `backends/cadence/aot/BUCK` and its dep references are left intact. Reviewed By: shobhitmehro Differential Revision: D115454520
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21793
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit a19e087 with merge base 3b5bf0f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115454520. |
maggiemoss
changed the title
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
Bot
added
the
release notes: none
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ExecuTorch Buck/Starlark build targets to stop opting open-source-synced Python code into type checking by removing per-target typing = True overrides, so typing behavior can be controlled by package-/repo-level defaults.
Changes:
- Removed
typing = Truefrom multiplefbcode_target(...)/runtime.python_library(...)definitions across Vulkan, Native, Test, and Cadence backend build targets. - Kept the Cadence
typing_stubstarget and dependency wiring intact while disabling type checking for the surrounding OSS-synced targets.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| backends/vulkan/patterns/BUCK | Removes typing = True from Vulkan patterns python library target. |
| backends/vulkan/partitioner/BUCK | Removes typing = True from Vulkan partitioner python library target. |
| backends/vulkan/_passes/targets.bzl | Removes typing = True from Vulkan passes target definition. |
| backends/test/targets.bzl | Removes typing = True from shared test builder python libraries. |
| backends/native/BUCK | Removes typing = True from the Native backend python library target. |
| backends/cadence/utils/targets.bzl | Removes typing = True from Cadence utility python library target. |
| backends/cadence/runtime/BUCK | Removes typing = True from Cadence runtime python library target. |
| backends/cadence/aot/quantizer/passes/BUCK | Removes typing = True from Cadence quantizer passes python library target. |
| backends/cadence/aot/quantizer/BUCK | Removes typing = True from Cadence quantizer-related python library targets. |
| backends/cadence/aot/BUCK | Removes typing = True from multiple Cadence AOT python library and python_unittest targets (including typing_stubs). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
126
to
130
| fbcode_target(_kind = runtime.python_library, | ||
| name = "ref_implementations", | ||
| srcs = [ | ||
| "ref_implementations.py", | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
this is intentional as typing = True is an outdated way to enable this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removing the typing = True from these buck files to clear the way for a more stable, easy to configure type checking set up
Reviewed By: shobhitmehro
Differential Revision: D115454520