Fix remaining CompileMode test regressions (#21801) - #21801
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21801
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 977977d with merge base 43f89fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115780184. |
This PR needs a
|
Summary: Stop applying `ReplaceConvWithChannelLastConvPass` to FP32 Cadence conv1d, conv2d, and conv3d operators. Their current seven-argument schemas are channel-first only; the pass retained a removed eighth `channel_last` argument and crashed DEFAULT compilation. Keep the pass limited to quantized operators that have explicit NCL/NCHW and NLC/NHWC targets, and add a regression test that FP32 conv2d remains untouched. Differential Revision: D115780184
8feea41 to
977977d
Compare
Summary:
Stop applying
ReplaceConvWithChannelLastConvPassto FP32 Cadence conv1d,conv2d, and conv3d operators. Their current seven-argument schemas are
channel-first only; the pass retained a removed eighth
channel_lastargumentand crashed DEFAULT compilation. Keep the pass limited to quantized operators
that have explicit NCL/NCHW and NLC/NHWC targets, and add a regression test that
FP32 conv2d remains untouched.
Differential Revision: D115780184