Skip to content

Fix remaining CompileMode test regressions (#21801) - #21801

Open
mcremon-meta wants to merge 1 commit into
mainfrom
export-D115780184
Open

Fix remaining CompileMode test regressions (#21801)#21801
mcremon-meta wants to merge 1 commit into
mainfrom
export-D115780184

Conversation

@mcremon-meta

@mcremon-meta mcremon-meta commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary:

Stop applying ReplaceConvWithChannelLastConvPass to FP32 Cadence conv1d,
conv2d, and conv3d operators. Their current seven-argument schemas are
channel-first only; the pass retained a removed eighth channel_last argument
and crashed DEFAULT compilation. Keep the pass limited to quantized operators
that have explicit NCL/NCHW and NLC/NHWC targets, and add a regression test that
FP32 conv2d remains untouched.

Differential Revision: D115780184

@pytorch-bot

pytorch-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21801

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 977977d with merge base 43f89fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2026
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115780184.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Stop applying `ReplaceConvWithChannelLastConvPass` to FP32 Cadence conv1d,
conv2d, and conv3d operators. Their current seven-argument schemas are
channel-first only; the pass retained a removed eighth `channel_last` argument
and crashed DEFAULT compilation. Keep the pass limited to quantized operators
that have explicit NCL/NCHW and NLC/NHWC targets, and add a regression test that
FP32 conv2d remains untouched.

Differential Revision: D115780184
@meta-codesync meta-codesync Bot changed the title Fix remaining CompileMode test regressions Fix remaining CompileMode test regressions (#21801) Aug 13, 2026
@meta-codesync
meta-codesync Bot force-pushed the export-D115780184 branch from 8feea41 to 977977d Compare August 13, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant