Skip to content

Retire attention-mask custom operator - #21802

Open
mcremon-meta wants to merge 1 commit into
pytorch:mainfrom
mcremon-meta:export-D115805406
Open

Retire attention-mask custom operator#21802
mcremon-meta wants to merge 1 commit into
pytorch:mainfrom
mcremon-meta:export-D115805406

Conversation

@mcremon-meta

Copy link
Copy Markdown
Contributor

Summary:
Retire the Jarvis attention-mask custom operator and all confirmed dead scaffolding.

Remove both the ExecuTorch jarvis_nn_ops::attention_mask.out runtime path and the unused eager jarvis_nn_ops::attention_mask wrapper. Delete their generic and HiFi kernels, tests, build targets, registrations, dependencies, and documentation. Remove custom-op-only PYE libraries, the orphan ASR encoder runtime package, unused ASR aggregate/HTP targets, and downstream references while preserving the live Jarvis NN aggregates and lean/non-HTP ASR operator bundles.

Differential Revision: D115805406

Summary:
Retire the Jarvis attention-mask custom operator and all confirmed dead scaffolding.

Remove both the ExecuTorch `jarvis_nn_ops::attention_mask.out` runtime path and the unused eager `jarvis_nn_ops::attention_mask` wrapper. Delete their generic and HiFi kernels, tests, build targets, registrations, dependencies, and documentation. Remove custom-op-only PYE libraries, the orphan ASR encoder runtime package, unused ASR aggregate/HTP targets, and downstream references while preserving the live Jarvis NN aggregates and lean/non-HTP ASR operator bundles.

Differential Revision: D115805406
@pytorch-bot

pytorch-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21802

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit cde4058 with merge base 43f89fb (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2026
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115805406.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant