Skip to content

Name the Python extension after what it contains - #21816

Open
shoumikhin wants to merge 2 commits into
gh/shoumikhin/106/headfrom
gh/shoumikhin/108/head
Open

Name the Python extension after what it contains#21816
shoumikhin wants to merge 2 commits into
gh/shoumikhin/106/headfrom
gh/shoumikhin/108/head

Conversation

@shoumikhin

Copy link
Copy Markdown
Contributor

The compiled Python extension in the wheel was called _portable_lib. That name
is misleading in two ways. "Portable" is the name of a kernel set in this project,
the portable kernels, and this file does not contain them: it holds the Python
bindings for the runtime. "Lib" says nothing, since every shared object is a
library. Someone looking for the portable kernels finds the Python bindings
instead, and someone looking for the bindings has no reason to open a file named
after kernels.

Rename it to _C, which is the usual name for a package's compiled C extension
and what PyTorch calls the same thing (torch/_C.cpython-*.so). The package path
already says pybindings, as in executorch.extension.pybindings, so a name like
_pybindings would repeat itself while _C reads as "this package's C
extension".

Nothing user facing changes. Applications import the public wrapper:

from executorch.extension.pybindings import portable_lib

That wrapper re-exports everything from the compiled module and keeps its name, so
existing code continues to work. Only the private module behind it is renamed, and
it was already documented as experimental and subject to change.

Test plan:

Built a wheel and confirmed the shipped file is named for the new module:

extension/pybindings/_C.cpython-312-x86_64-linux-gnu.so

Installed that wheel into a fresh environment and checked both the public wrapper
and the private module load, then exported and ran a model through the Python
bindings:

public wrapper works: True
module name         : executorch.extension.pybindings._C
exported symbols    : 22

Also grepped the tree to confirm no build file, test, or comment still names the
old module.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21816

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@shoumikhin
shoumikhin requested a deployment to cadence August 13, 2026 17:38 — with GitHub Actions Pending
@shoumikhin
shoumikhin requested a deployment to cadence August 13, 2026 17:38 — with GitHub Actions Pending
shoumikhin added a commit that referenced this pull request Aug 13, 2026
The compiled Python extension in the wheel was called `_portable_lib`. That name
is misleading in two ways. "Portable" is the name of a kernel set in this project,
the portable kernels, and this file does not contain them: it holds the Python
bindings for the runtime. "Lib" says nothing, since every shared object is a
library. Someone looking for the portable kernels finds the Python bindings
instead, and someone looking for the bindings has no reason to open a file named
after kernels.

Rename it to `_C`, which is the usual name for a package's compiled C extension
and what PyTorch calls the same thing (`torch/_C.cpython-*.so`). The package path
already says `pybindings`, as in `executorch.extension.pybindings`, so a name like
`_pybindings` would repeat itself while `_C` reads as "this package's C
extension".

Nothing user facing changes. Applications import the public wrapper:

```python
from executorch.extension.pybindings import portable_lib
```

That wrapper re-exports everything from the compiled module and keeps its name, so
existing code continues to work. Only the private module behind it is renamed, and
it was already documented as experimental and subject to change.

Test plan:

Built a wheel and confirmed the shipped file is named for the new module:

```
extension/pybindings/_C.cpython-312-x86_64-linux-gnu.so
```

Installed that wheel into a fresh environment and checked both the public wrapper
and the private module load, then exported and ran a model through the Python
bindings:

```
public wrapper works: True
module name         : executorch.extension.pybindings._C
exported symbols    : 22
```

Also grepped the tree to confirm no build file, test, or comment still names the
old module.

ghstack-source-id: 20f23fe
ghstack-comment-id: 5282557165
Pull-Request: #21816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant