Skip to content

Return 404 when recording a payment for a packet that doesn't exist - #645

Merged
geoffrey-wu merged 1 commit into
mainfrom
geoword-set-payments.5-missing-packet
Oct 27, 2026
Merged

geoffrey-wu merged 1 commit into
mainfrom
geoword-set-payments.5-missing-packet

Conversation

@geoffrey-wu

@geoffrey-wu geoffrey-wu commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Sixth of the stack, on top of #644. A site admin passes the admin router's permission check for a packetName that doesn't exist, and recordPayment then threw. record-payment now returns 404 first, and the manage-payments page alerts "Packet not found".

Lint passes; not exercised in the browser.

🤖 Generated with Claude Code

@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch from d577354 to 3362494 Compare October 24, 2026 22:56
@geoffrey-wu
geoffrey-wu added this pull request to stack #646 October 24, 2026 23:36
@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch 2 times, most recently from b7a2d91 to 3f8abca Compare October 27, 2026 03:48
@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch 3 times, most recently from 4483bab to 4ed106e Compare October 27, 2026 04:03
@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch from 4ed106e to 4751e2f Compare October 27, 2026 04:04
@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch 2 times, most recently from 935affd to d709ffe Compare October 27, 2026 04:10
Base automatically changed from geoword-set-payments.4-recorded-by to main October 27, 2026 04:16
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@geoffrey-wu
geoffrey-wu force-pushed the geoword-set-payments.5-missing-packet branch from d709ffe to b72cc83 Compare October 27, 2026 04:16
@geoffrey-wu
geoffrey-wu merged commit 088b5aa into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant