Skip to content

Device Tree Changes for LT9611C#763

Open
mohitdsor wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:fix/my-second-change
Open

Device Tree Changes for LT9611C#763
mohitdsor wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:fix/my-second-change

Conversation

@mohitdsor

@mohitdsor mohitdsor commented Jun 23, 2026

Copy link
Copy Markdown

Device Tree Changes for LT9611C
CRs-Fixed: 4552827

@mohitdsor mohitdsor changed the base branch from main to qcom-6.18.y June 23, 2026 16:10
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4552827 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4552827
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from 890eadc to ba35046 Compare June 23, 2026 21:01

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post patch Upstream and bring as FROMLIST

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from ba35046 to d088a35 Compare June 27, 2026 18:45
@qcomlnxci qcomlnxci requested a review from a team June 27, 2026 18:47
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable for comparison
  3. Upstream patch status: In review — PENDING: prefix indicates not yet merged; message-ID dated 2026-06-27 (4 days after patch authorship)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #763 - PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/ (cannot verify - network restricted)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable; PENDING: prefix indicates not yet merged
Body preserves rationale ⚠️ Minimal description; lacks detail on hardware configuration, pin assignments, or why changes are needed
Fixes tag present/correct N/A Not a fix; new hardware support
Authorship preserved Author: Mohit Dsor mohit.dsor@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport; PENDING: prefix indicates under review upstream

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Spaces instead of tabs in &pm8150_l11 block (lines 140-143); trailing blank lines at EOF

Issues

  • Whitespace: The &pm8150_l11 regulator block uses spaces for indentation instead of tabs (DTS convention requires tabs)
  • Trailing whitespace: Two blank lines added at end of file (line 180-181) instead of single newline
  • Commit message: Body is too terse; should explain what hardware is being enabled, why these specific regulators/pins are needed, and reference the bridge driver
  • Date mismatch: Patch authored June 23, lore message-id dated June 27 (v1-5 suggests part of series; date difference expected but worth noting)
  • PENDING prefix: Indicates patch not yet accepted upstream; appropriate for review but signals work-in-progress status

Verdict

Requires minor fixes before merge: correct indentation in &pm8150_l11 block (tabs not spaces), remove trailing blank lines, and optionally expand commit message body with hardware context.

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable for comparison
  3. Upstream patch status: In review — PENDING: prefix indicates not yet merged; message-ID dated 2026-06-27 (4 days after patch authorship)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28298443164

Checker Result Summary
Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues + undocumented compatible
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Schema validation failure: lontium,lt9611uxd has no matching schema
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "PENDING:" not allowed
tag-check N/A Not applicable for this PR
qcom-next-check N/A Not applicable (PENDING prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28298443164

Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues + undocumented compatible
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Schema validation failure: lontium,lt9611uxd has no matching schema
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "PENDING:" not allowed
tag-check N/A Not applicable for this PR
qcom-next-check N/A Not applicable (PENDING prefix)

❌ checkpatch

Root cause: Mixed use of spaces instead of tabs for indentation in &pm8150_l11 node (lines 541-544), plus multiple blank lines and undocumented compatible string.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented
#70: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:370:
+		compatible = "lontium,lt9611uxd";

CHECK: Please don't use multiple blank lines
#138: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:539:

ERROR: code indent should use tabs where possible
#140: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541:
+        /* DSI VDDA - must be at NOM voltage for PHY PLL lock */

ERROR: code indent should use tabs where possible
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;

WARNING: please, no spaces at the start of a line
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;

ERROR: code indent should use tabs where possible
#142: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:543:
+        regulator-max-microvolt = <1232000>;

ERROR: code indent should use tabs where possible
#143: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:544:
+        regulator-allow-set-load;

CHECK: Please don't use multiple blank lines
#181: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:806:

Total: 4 errors, 4 warnings, 2 checks

Fix:

  1. Replace spaces with tabs in the &pm8150_l11 block (lines 541-544 in the patch)
  2. Remove extra blank lines at line 539 and line 806
  3. The undocumented compatible warning is expected if the binding hasn't been merged yet (see dtb-check below)

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..d088a35b9ce70817524a620fdadaea8fd1ebbd1b

❌ dtb-check

Root cause: The compatible string lontium,lt9611uxd has no matching device tree binding schema in Documentation/devicetree/bindings/.

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

Fix:
This PR adds device tree nodes for the LT9611UXD HDMI-DSI bridge, but the corresponding device tree binding documentation is missing. You need to either:

  1. Add the binding first (recommended upstream approach):

    • Create Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml
    • Submit the binding as a separate patch before the DTS changes
    • Reference: The lore link in the commit message suggests this is part of a series
  2. Or verify the binding exists upstream:

    • Check if the binding was already merged in mainline
    • If yes, ensure your tree is rebased on a version that includes it

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: Commit subject starts with "PENDING:" which is not an allowed prefix for the Qualcomm Linux kernel tree.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Commit summary does not start with a required prefix

Fix:
Replace the "PENDING:" prefix with one of the allowed prefixes:

  • FROMLIST: - if the patch is posted to an upstream mailing list but not yet merged
  • UPSTREAM: - if the patch is already merged in mainline
  • BACKPORT: - if backporting from a newer kernel version
  • Or use the standard subsystem prefix: arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge support

Based on the lore link in the commit message (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/), this appears to be posted upstream, so use:

FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support

Reproduce locally:

# Check the commit prefix policy
bash kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 8c49474603c0b1c278b8fe00ac4e735b92d78ce9 \
  --head d088a35b9ce70817524a620fdadaea8fd1ebbd1b

Verdict

3 blockers must be fixed before merge:

  1. Checkpatch whitespace errors - Replace spaces with tabs in &pm8150_l11 block and remove extra blank lines
  2. Missing DT binding schema - Add Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml or verify it exists upstream
  3. Invalid commit prefix - Change "PENDING:" to "FROMLIST:" (or appropriate prefix)

The checkpatch issues are trivial formatting fixes. The dtb-check failure indicates a missing binding document that should be added/merged before the DTS changes. The compliance check requires updating the commit subject prefix to follow Qualcomm kernel conventions.

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from d088a35 to bf4bf52 Compare June 27, 2026 21:55
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
6 Full report

Final Summary

  1. Lore link present: No — FROMLIST prefix used but no Link: tag provided in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Cannot determine — no lore link provided; searches on lore.kernel.org found no matching patch from this author
  4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Required Actions:

  • If posted upstream: Add Link: https://lore.kernel.org/r/<message-id> tag before Signed-off-by
  • If not posted upstream: Change FROMLIST: to QCLINUX: and remove Upstream-Status tag
  • Expand commit message body with technical rationale
  • Fix whitespace issues (trailing blank lines, inconsistent spacing)
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #763 - arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: N/A (no lore link provided)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No lore link provided; cannot verify upstream match
Body preserves rationale ⚠️ Minimal description; no technical rationale for changes
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Author: Mohit Dsor mohit.dsor@oss.qualcomm.com
Backport note (if applicable) FROMLIST prefix requires Link: tag to lore posting

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Cannot verify against upstream without lore link

Issues

Critical:

  1. Missing lore link: Patch uses FROMLIST: prefix but provides no Link: tag pointing to the upstream posting on lore.kernel.org
  2. Contradictory tags: FROMLIST: implies the patch is posted upstream for review, but Upstream-Status: Inappropriate [debug specific] suggests it's not intended for upstream
  3. Incomplete commit message: Body contains only one line with no technical justification for the hardware enablement

Commit Message Requirements:

  • FROMLIST patches MUST include a Link: tag with the lore.kernel.org URL (e.g., Link: https://lore.kernel.org/r/<message-id>)
  • The commit body should explain what hardware is being enabled and why these specific DT nodes are needed
  • Either remove FROMLIST: and use QCLINUX: for vendor-only changes, OR provide the upstream lore link

Style Issues:

  • Extra blank lines at end of file (lines 807-808)
  • Inconsistent spacing before &pm8150_gpios block (double newline at line 538)
  • Mixed indentation style (spaces vs tabs) in &pm8150_l11 block (line 541)

Verdict

Reject — Patch cannot be validated without upstream lore link. The FROMLIST prefix requires a Link: tag to the mailing list posting. If this is vendor-specific debug code not intended for upstream, use QCLINUX: prefix instead and remove the Upstream-Status tag.

Final Summary

  1. Lore link present: No — FROMLIST prefix used but no Link: tag provided in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Cannot determine — no lore link provided; searches on lore.kernel.org found no matching patch from this author
  4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Required Actions:

  • If posted upstream: Add Link: https://lore.kernel.org/r/<message-id> tag before Signed-off-by
  • If not posted upstream: Change FROMLIST: to QCLINUX: and remove Upstream-Status tag
  • Expand commit message body with technical rationale
  • Fix whitespace issues (trailing blank lines, inconsistent spacing)

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28303023174

Checker Result Summary
Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Undocumented compatible string 'lontium,lt9611uxd'
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing 'Link:' tag in commit message
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28303023174

Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Undocumented compatible string 'lontium,lt9611uxd'
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing 'Link:' tag in commit message
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ checkpatch

Root cause: Whitespace and indentation errors in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541-544

Failure details:

ERROR: code indent should use tabs where possible
#140: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541:
+        /* DSI VDDA - must be at NOM voltage for PHY PLL lock */$

ERROR: code indent should use tabs where possible
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;$

WARNING: please, no spaces at the start of a line
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;$

ERROR: code indent should use tabs where possible
#142: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:543:
+        regulator-max-microvolt = <1232000>;$

ERROR: code indent should use tabs where possible
#143: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:544:
+        regulator-allow-set-load;$

CHECK: Please don't use multiple blank lines
#138: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:539:
+
+

CHECK: Please don't use multiple blank lines
#183: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:808:
+
+

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented

Fix:

  1. Replace spaces with tabs in lines 541-544 of the &pm8150_l11 block
  2. Remove extra blank lines at lines 539 and 808
  3. Document the compatible string (see dtb-check fix below)

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..HEAD

❌ dtb-check

Root cause: Compatible string lontium,lt9611uxd is not documented in device tree bindings

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: 
i2c@4a90000 (qcom,geni-i2c): 'lt,lt9611uxd@41' does not match any of the regexes: ...

arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: 
/soc@0/geniqup@4ac0000/i2c@4a90000/lt,lt9611uxd@41: failed to match any schema with compatible: ['lontium,lt9611uxd']

Fix:

  1. Add device tree binding documentation for lontium,lt9611uxd in Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml
  2. OR use the existing documented compatible string if one exists (check Documentation/devicetree/bindings/display/bridge/ for similar Lontium chips like lt9611 or lt9611uxc)
  3. If this is a variant of an existing chip, consider using the base compatible as a fallback

Reproduce locally:

make O=temp-out defconfig
make O=temp-out CHECK_DTBS=y qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: Commit message missing required Link: tag for FROMLIST commits

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
No 'Link' found in commit message

Fix:
Add a Link: tag to the commit message pointing to the upstream mailing list submission. The commit message should follow this format:

FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support

Device tree changes to support lt9611uxd hdmi-dsi driver.

Link: https://lore.kernel.org/...
Upstream-Status: Inappropriate [debug specific]
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>

If the patch hasn't been submitted upstream yet, consider using DOWNSTREAM: prefix instead of FROMLIST:, or submit it upstream first.

Reproduce locally:

git log -1 --format=%B | grep -q "^Link:" || echo "Missing Link tag"

Verdict

3 blockers must be fixed before merge:

  1. checkpatch - Fix whitespace/indentation (use tabs, remove extra blank lines)
  2. dtb-check - Document the lontium,lt9611uxd compatible string or use existing documented compatible
  3. check-patch-compliance - Add Link: tag to commit message or change prefix from FROMLIST: to DOWNSTREAM:

The fixes are straightforward: clean up whitespace, add DT binding documentation, and update the commit message with proper tags.

output-high;
};
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra lines

@sgaud-quic

Copy link
Copy Markdown
Contributor

No link in commit log

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from bf4bf52 to 09c6dfb Compare June 29, 2026 13:42
@qcomlnxci qcomlnxci requested a review from a team June 29, 2026 13:44
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to lore.kernel.org message-ID (v1 series, patch 5)

  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patch for comparison

  3. Upstream patch status: Unknown — Cannot determine acceptance status due to network restrictions; message-ID format suggests recent v1 submission (2026-06-27), likely still in review

  4. PR present in qcom-next: Not checked — No kernel tree access per task constraints

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #763 - arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; subject format acceptable but could be more specific
Body preserves rationale Body is too brief: "Device tree changes to support lt9611uxd hdmi-dsi driver." Missing hardware details, board context, and change explanation
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Author mismatch: From: Vishnu Saini but first SoB: Mohit Dsor. Original author should be in From: field
Backport note (if applicable) N/A Appears to be new upstream submission (v1 series)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:23 Critical indentation error: hdmi-connector, vreg_lt9611_vcc, vreg_lt9611_vdd nodes inserted at wrong nesting level (1 tab vs 3 tabs expected based on context)
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:93 i2c4 node properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:131 mdss/dsi nodes properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:150 pm8150 nodes properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:165 tlmm pinctrl nodes properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:183 ⚠️ uart0 enablement - unrelated to LT9611UXD HDMI bridge; should be separate commit or explained in commit message

Issues

Critical:

  1. Indentation corruption (lines 23-52): The hdmi-connector and two regulator nodes are inserted at the root level (1 tab indent) when they should be nested inside the parent node at 3-tab indent level. The context line shows sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; at 4-tab indent, followed by closing braces, suggesting these new nodes should be siblings at the same parent level, not at root.

  2. Authorship mismatch: Patch From: field lists Vishnu Saini, but first Signed-off-by: is Mohit Dsor. Per kernel DCO rules, the author (From:) must match the first SoB. If Mohit is the original author, the From: field should be From: Mohit Dsor with Vishnu's SoB second (indicating he applied/forwarded the patch).

Major:
3. Insufficient commit body: The description "Device tree changes to support lt9611uxd hdmi-dsi driver" lacks essential context:

  • What hardware is being enabled (LT9611UXD HDMI-to-DSI bridge)
  • Which board (Shikra IQS EVK)
  • What functionality is added (HDMI output via DSI0)
  • Component summary (regulators, I2C device, MDSS/DSI config, pinctrl)

Minor:
4. Unrelated change: uart0 enablement (line 183) is not explained in the commit message and appears unrelated to HDMI bridge support. Should either be removed or explained.

  1. Subject could be more specific: Current: "arm64: dts: qcom: Shikra LT9611UXD support"
    Better: "arm64: dts: qcom: shikra-iqs-evk: Add LT9611UXD HDMI bridge support"

Verdict

Reject - The patch contains a critical indentation error that will cause DTS compilation failure or incorrect device tree structure. The authorship must be corrected to comply with kernel DCO requirements. The commit message needs substantial improvement to meet upstream standards.

Final Summary

  1. Lore link present: Yes — Link tag points to lore.kernel.org message-ID (v1 series, patch 5)

  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patch for comparison

  3. Upstream patch status: Unknown — Cannot determine acceptance status due to network restrictions; message-ID format suggests recent v1 submission (2026-06-27), likely still in review

  4. PR present in qcom-next: Not checked — No kernel tree access per task constraints

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28376598217

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No DT binding changes
dtb-check Failed to match schema for lt9611uxd; sound card validation error
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix (UPSTREAM:/FROMLIST:)
tag-check N/A Not applicable for this branch
qcom-next-check Requires FROMLIST:/UPSTREAM: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28376598217

Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No DT binding changes
dtb-check Failed to match schema for lt9611uxd; sound card validation error
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix (UPSTREAM:/FROMLIST:)
tag-check N/A Not applicable for this branch
qcom-next-check Requires FROMLIST:/UPSTREAM: prefix

❌ checkpatch

Root cause: The compatible string lontium,lt9611uxd is used in the DTS but lacks corresponding documentation in Documentation/devicetree/bindings/.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented -- check ./Documentation/devicetree/bindings/
#64: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:489:
+		compatible = "lontium,lt9611uxd";

09c6dfb04e219bd7542d85f2eca1830bf346230f total: 0 errors, 1 warnings, 0 checks, 140 lines checked

Fix:

  1. Ensure the DT binding for lontium,lt9611uxd exists in Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml (or similar path)
  2. If the binding is being added in a separate patch/series, this warning can be ignored if the binding patch is merged first
  3. The lore link in the commit message (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/) suggests this is part of a series - verify the binding patch is included

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..08b1575c1204e4124212c50884eb96cc6650980f

❌ dtb-check

Root cause: Two validation failures:

  1. The lontium,lt9611uxd compatible string has no matching DT schema
  2. The sound card node has unexpected child nodes (hdmi-connector, regulator-lt9611-vcc, regulator-lt9611-vdd) that don't match the qcom,sm8250.yaml schema pattern

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: failed to match any schema with compatible: ['lontium,lt9611uxd']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: sound (qcom,shikra-iqs-sndcard): va-dmic-dai-link: 'hdmi-connector', 'regulator-lt9611-vcc', 'regulator-lt9611-vdd' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/sound/qcom,sm8250.yaml#

Fix:

  1. Missing schema: Add or ensure the DT binding schema for lontium,lt9611uxd exists at Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml

  2. Sound card validation: The regulators and hdmi-connector nodes are being added as children of the sound card node, but they should be top-level nodes in the root of the device tree (not under the sound card). Move these nodes:

    • hdmi-connector should be at root level (already is in the patch)
    • vreg_lt9611_vcc should be at root level (already is in the patch)
    • vreg_lt9611_vdd should be at root level (already is in the patch)

    The issue appears to be that the patch has incorrect indentation - the nodes are being added inside the sound card's va-dmic-dai-link section instead of at the root level. Check lines around the hdmi-connector node in the patch.

Reproduce locally:

# Build DTBs with validation
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml
# Or check specific DTB
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: The commit subject line does not start with a required prefix (UPSTREAM: or FROMLIST:).

Failure details:

Checking commit: arm64: dts: qcom: Shikra LT9611UXD support
Commit summary does not start with a required prefix

Fix:
The commit message references a lore.kernel.org link, indicating this is a patch from an upstream mailing list. Update the commit subject to include the appropriate prefix:

  • If the patch is already merged upstream: UPSTREAM: arm64: dts: qcom: Shikra LT9611UXD support
  • If the patch is posted to a mailing list but not yet merged: FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support

Based on the lore link (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/), this appears to be a FROMLIST patch.

Reproduce locally:

# Check the commit message format
git log --oneline 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..da1ce885728f5f47eab00d488d7013caa6e21892

Verdict

3 blockers must be fixed before merge:

  1. Critical: Fix DTS indentation issue causing sound card schema validation failure (dtb-check)
  2. Critical: Add FROMLIST: or UPSTREAM: prefix to commit subject (check-patch-compliance)
  3. Dependency: Ensure the lontium,lt9611uxd DT binding schema is present or merged first (checkpatch + dtb-check)

The patch appears to be part of a series (v1-5 from the lore link). Verify that the DT binding patch (likely v1-1 through v1-4) is included in this PR or has already been merged to the target branch.

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from 09c6dfb to 2ea7265 Compare June 29, 2026 14:35
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes - Link tag points to https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching upstream patch; unable to compare diff, subject, or authorship

  3. Upstream patch status: Cannot determine - lore.kernel.org unreachable; FROMLIST prefix indicates patch was posted to mailing list but acceptance status unknown

  4. PR present in qcom-next: Not checked - no kernel tree access per task constraints

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable due to network restrictions
Body preserves rationale ⚠️ Body is minimal ("Device tree changes to support lt9611uxd hdmi-dsi driver") - typical for DT patches but lacks detail
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ⚠️ Cannot verify against upstream; dual sign-off present (Mohit Dsor → Vishnu Saini)
Backport note (if applicable) N/A FROMLIST prefix indicates not yet upstream

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:23-51 Critical indentation error: hdmi-connector and regulator nodes use single-tab indent but are inserted between triple-indented sound nodes - breaks DT hierarchy
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:60-96 i2c4 node and lt9611uxd device properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:98-108 mdss/dsi nodes correctly structured
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:110-120 pm8150 gpio and regulator config looks correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:140-152 tlmm pinctrl nodes properly formatted
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:154-156 ⚠️ uart0 enablement - unrelated to HDMI/DSI bridge; should be separate commit or explained

Issues

Critical:

  1. Indentation/hierarchy error (lines 23-51): The hdmi-connector, vreg_lt9611_vcc, and vreg_lt9611_vdd nodes are inserted with incorrect indentation. They appear between a closing }; at line 22 (ending a sound-dai node with 3-tab indent) and a platform { node at line 54 (also 3-tab indent). The new nodes use only 1-tab indent, suggesting they should be at root level but are placed in the wrong location. This will likely cause DT compilation errors or incorrect device tree structure.

Minor:
2. Unrelated change: The &uart0 enablement (lines 154-156) is unrelated to LT9611UXD HDMI-DSI bridge support. Per kernel patch guidelines, unrelated changes should be in separate commits.

  1. Commit message lacks detail: The body only states "Device tree changes to support lt9611uxd hdmi-dsi driver" without explaining what hardware is being enabled, why, or any relevant context (e.g., "Enable LT9611UXD HDMI-to-DSI bridge on Shikra IQS EVK to support HDMI output via DSI0").

Cannot verify:
4. Network restrictions prevent fetching the upstream patch from lore.kernel.org to verify diff faithfulness, subject line accuracy, or authorship chain.

Verdict

Do not merge as-is. The indentation error at lines 23-51 is a critical structural defect that will break the device tree. The patch must be corrected to place the hdmi-connector and regulator nodes at the proper hierarchy level (likely as root-level nodes under / with single-tab indent, but the context suggests they may need to be elsewhere). Additionally, the uart0 change should be split into a separate commit or justified in the commit message.

Final Summary

  1. Lore link present: Yes - Link tag points to https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/

  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching upstream patch; unable to compare diff, subject, or authorship

  3. Upstream patch status: Cannot determine - lore.kernel.org unreachable; FROMLIST prefix indicates patch was posted to mailing list but acceptance status unknown

  4. PR present in qcom-next: Not checked - no kernel tree access per task constraints

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28380038533

Checker Result Summary
Checker Result Summary
checkpatch WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Failed to match schema for "lontium,lt9611uxd" + sound card schema violation
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Author mismatch: original author vs commit author
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit compliant

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28380038533

Checker Result Summary
checkpatch WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Failed to match schema for "lontium,lt9611uxd" + sound card schema violation
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Author mismatch: original author vs commit author
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit compliant

❌ checkpatch

Root cause: The DT compatible string lontium,lt9611uxd is used in the device tree but lacks corresponding documentation in Documentation/devicetree/bindings/.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented -- check ./Documentation/devicetree/bindings/
#64: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:489:
+		compatible = "lontium,lt9611uxd";

Fix: This is a FROMLIST patch, so the binding documentation should exist in the upstream series. Verify that:

  1. The binding document exists in the upstream patch series on lore (link: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/)
  2. If this is part of a multi-patch series, ensure the binding patch is applied before the DTS patch
  3. If the binding is already upstream, cherry-pick it first

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..005adf5a2c10ec0fae9338806f05028706e2dd10

❌ dtb-check

Root cause: Two schema validation failures: (1) no DT binding schema found for lontium,lt9611uxd, and (2) the sound card schema (qcom,sm8250.yaml) does not allow hdmi-connector, regulator-lt9611-vcc, and regulator-lt9611-vdd as top-level nodes under the sound card.

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: failed to match any schema with compatible: ['lontium,lt9611uxd']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: sound (qcom,shikra-iqs-sndcard): va-dmic-dai-link: 'hdmi-connector', 'regulator-lt9611-vcc', 'regulator-lt9611-vdd' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/sound/qcom,sm8250.yaml#

Fix:

  1. For the lt9611uxd schema failure: Same as checkpatch - ensure the DT binding for lontium,lt9611uxd is present. Check the upstream series and apply the binding patch first.

  2. For the sound card schema failure: The nodes hdmi-connector, regulator-lt9611-vcc, and regulator-lt9611-vdd are incorrectly placed. Looking at the patch structure in pr.patch:93-122, these nodes appear to be indented incorrectly - they should be at the root level (under /), not under the sound card node. The patch shows incorrect indentation starting at line 93 where hdmi-connector is added inside the sound card's va-dmic-dai-link section instead of at the root level.

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: The commit author (Vishnu Saini <vishnu.saini@oss.qualcomm.com>) does not match the original patch author from the lore link (Mohit Dsor <mohit.dsor@oss.qualcomm.com>).

Failure details:

Author mismatch:
  Original author: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
  Commit author : Vishnu Saini <vishnu.saini@oss.qualcomm.com>

Fix: When applying patches from upstream, preserve the original author. Use one of these approaches:

  1. If applying with git am: The author is preserved automatically
  2. If cherry-picking: Use git cherry-pick -x <commit>
  3. If manually applying: Use git commit --author="Mohit Dsor <mohit.dsor@oss.qualcomm.com>"
  4. To fix this commit:
    git commit --amend --author="Mohit Dsor <mohit.dsor@oss.qualcomm.com>"
    Then add Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com> as a co-developer sign-off in the commit message body.

Reproduce locally:

git log --format="%an <%ae>" HEAD~1..HEAD
# Compare with the lore link author

Verdict

3 blockers must be fixed before merge:

  1. Critical DT structure issue: The hdmi-connector and regulator nodes are incorrectly nested inside the sound card node instead of being at the root level. This is a structural error in the patch itself.

  2. Missing DT binding: Apply the lontium,lt9611uxd binding documentation patch from the upstream series before this DTS patch.

  3. Author attribution: Preserve the original author (Mohit Dsor) and add co-developer sign-offs as needed.

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from 2ea7265 to 77e937d Compare June 29, 2026 15:31
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - Link tag points to lore.kernel.org message-ID 20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot determine - network access restricted; FROMLIST prefix indicates patch is posted but not yet merged
  4. PR present in qcom-next: Not checked - no kernel tree access per constraints
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; subject format is valid
Body preserves rationale ⚠️ Minimal description; lacks detail on hardware integration
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Author: Mohit Dsor mohit.dsor@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST prefix present; Link tag included

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:23-51 Critical: Incorrect indentation - new top-level nodes use 1 tab but should match parent context (appears to be 3+ tabs based on surrounding platform node)
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:485-524 i2c4 node addition looks structurally correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:526-540 mdss/dsi nodes look correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542-548 pm8150_gpios pinctrl addition looks correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:550-555 pm8150_l11 regulator config looks correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:700-716 tlmm pinctrl additions look correct
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:718-720 ⚠️ uart0 enablement - unrelated to LT9611UXD; should be separate commit

Issues

Critical:

  1. Indentation mismatch at lines 23-51: The three new top-level device nodes (hdmi-connector, vreg_lt9611_vcc, vreg_lt9611_vdd) are inserted with single-tab indentation, but the surrounding context shows they should be indented to match the parent scope. The following platform { node has 3-tab indentation, suggesting these new nodes are at the wrong nesting level or incorrectly indented.

Minor:
2. Scope creep: The &uart0 enablement (lines 718-720) is unrelated to LT9611UXD HDMI bridge support and should be in a separate commit.
3. Commit message brevity: The body "Device tree changes to support lt9611uxd hdmi-dsi driver" is too terse. A proper upstream commit would explain what hardware is being enabled, why, and provide context (e.g., "Enable the Lontium LT9611UXD HDMI-to-DSI bridge on Shikra IQS EVK, connecting DSI0 to an HDMI type-A connector. Add required regulators and pinctrl configuration.").

Verdict

Reject - The patch contains a critical indentation error that will break the device tree structure. The new nodes at lines 23-51 must be re-indented to match the correct parent scope. Additionally, the unrelated uart0 change should be split into a separate commit.

Final Summary

  1. Lore link present: Yes - Link tag points to lore.kernel.org message-ID 20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot determine - network access restricted; FROMLIST prefix indicates patch is posted but not yet merged
  4. PR present in qcom-next: Not checked - no kernel tree access per constraints

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28383679848

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ No binding changes in this PR
dtb-check Schema validation failures for lt9611uxd device
sparse-check ⏭️ Skipped (DTS-only patch)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit compliant

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28383679848

Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ No binding changes in this PR
dtb-check Schema validation failures for lt9611uxd device
sparse-check ⏭️ Skipped (DTS-only patch)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit compliant

❌ checkpatch

Root cause: The compatible string "lontium,lt9611uxd" used in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:489 is not documented in Documentation/devicetree/bindings/.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented -- check ./Documentation/devicetree/bindings/
#64: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:489:
+		compatible = "lontium,lt9611uxd";

77e937dcab265ff02a8d1a6f82f0d4426ab25f64 total: 0 errors, 1 warnings, 0 checks, 140 lines checked

Fix: This is expected for a FROMLIST patch. The device tree binding documentation should be submitted upstream first (or as part of the same series). Verify that:

  1. The upstream lore link (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/) includes the binding documentation in an earlier patch of the series
  2. The binding has been reviewed/accepted upstream before merging this DTS change

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..09c1fbd17efcfaf13e017cca328e91dd6cf1e118

❌ dtb-check

Root cause: The device tree blob validation fails because the schema for "lontium,lt9611uxd" is missing, and the sound card node has additional child nodes that don't match the expected schema pattern.

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: 
  sound (qcom,shikra-iqs-sndcard): va-dmic-dai-link: 
  'hdmi-connector', 'regulator-lt9611-vcc', 'regulator-lt9611-vdd' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/sound/qcom,sm8250.yaml#

Analysis:

  1. Missing schema for lt9611uxd: The DT schema validation cannot find a binding for lontium,lt9611uxd. This is expected for FROMLIST patches where the binding hasn't been merged yet.

  2. Sound card schema violation: The sound card node (qcom,shikra-iqs-sndcard) is adding three new top-level child nodes (hdmi-connector, regulator-lt9611-vcc, regulator-lt9611-vdd) at the wrong level. According to the error, these nodes don't match the expected pattern ^pinctrl-[0-9]+$ for additional properties under the sound card node.

Fix:

For the lt9611uxd schema issue:

  • This is expected for FROMLIST patches. The binding documentation must be submitted and ideally accepted upstream first.
  • Verify the upstream series includes the binding YAML file (likely Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml)

For the sound card schema issue:

  • The three nodes (hdmi-connector, regulator-lt9611-vcc, regulator-lt9611-vdd) should NOT be children of the sound card node
  • These should be top-level nodes under the root / node, not nested under sound
  • Looking at the patch, the indentation appears incorrect. The nodes starting at line 93 (hdmi-connector), line 105 (vreg_lt9611_vcc), and line 117 (vreg_lt9611_vdd) are indented as if they're children of the sound card, but they should be at the same level as the sound card itself

Correct structure should be:

/ {
	sound {
		...
	};

	hdmi-connector {
		...
	};

	vreg_lt9611_vcc: regulator-lt9611-vcc {
		...
	};

	vreg_lt9611_vdd: regulator-lt9611-vdd {
		...
	};
};

Reproduce locally:

# Build with dtbs_check enabled
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-iqs-evk.dtb

Verdict

2 blockers must be fixed before merge:

  1. Critical: DTS indentation/structure error - The hdmi-connector, regulator-lt9611-vcc, and regulator-lt9611-vdd nodes are incorrectly nested under the sound card node. They must be moved to the root level of the device tree.

  2. Expected for FROMLIST: Missing binding documentation - The lontium,lt9611uxd compatible string lacks documentation. Verify the upstream series includes the binding YAML in an earlier patch. This is acceptable for FROMLIST patches if the binding is part of the same upstream series.

Action required: Fix the DTS structure by correcting the indentation of the three regulator/connector nodes to be root-level nodes, not children of the sound card.

@sgaud-quic

Copy link
Copy Markdown
Contributor

Mainline PR is not yet merged :
qualcomm-linux/kernel-topics#1428

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Device tree changes to support lt9611uxd hdmi-dsi driver.

Link: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to lore.kernel.org message-ID
  2. Lore link matches PR commits: Cannot verify — network restricted; lore.kernel.org unreachable during validation
  3. Upstream patch status: Unknown — cannot fetch from lore due to network restrictions
  4. PR present in qcom-next: No — but a related commit 9896f69f0a12 exists with same feature but significantly different implementation
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/ (network restricted, cannot fetch)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; lore.kernel.org unreachable
Body preserves rationale ⚠️ Minimal description; cannot compare to upstream
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved ⚠️ Author email differs from qcom-next version (oss.qualcomm.com vs qti.qualcomm.com)
Backport note (if applicable) FROMLIST prefix present; Link tag included

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:27 Significant differences from qcom-next commit 9896f69

Issues

Critical: PR patch differs substantially from qcom-next version

The PR patch claims to be FROMLIST (upstream submission) but differs significantly from the already-merged qcom-next commit 9896f69f0a12 by the same author for the same feature:

  1. Regulator design changed:

    • PR uses separate vreg_lt9611_vcc and vreg_lt9611_vdd regulators
    • qcom-next uses single lcd_bias regulator with vin-supply
  2. Device node properties differ:

    • PR: node name lt9611uxd@41, has vcc-supply/vdd-supply, lontium,port-select = <1>, interrupt IRQ_TYPE_EDGE_FALLING
    • qcom-next: node name lt,lt9611uxd@41, has hdmi-gpios, interrupt IRQ_TYPE_EDGE_RISING, no port-select
  3. Pinctrl configuration differs:

    • PR: hdmi_reg_en uses PMIC_GPIO_FUNC_NORMAL, lt9611_irq_pin has bias-pull-up
    • qcom-next: lcd_bias_en uses function = "gpio", lt9611_irq_pin has bias-disable + input-enable
  4. Additional changes in PR not in qcom-next:

    • PR adds pm8150_l11 regulator configuration
    • PR enables uart0 (unrelated to HDMI bridge)
  5. Subject line mismatch:

    • PR: "FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support"
    • qcom-next: "arm64: dts: qcom: shikra: Add lt9611uxd node to IQS EVK board"

Authorship concern: Author email changed from mdsor@qti.qualcomm.com (qcom-next) to mohit.dsor@oss.qualcomm.com (PR), and added second Signed-off-by from Vishnu Saini.

uart0 enablement: Unrelated change that should be in separate commit.

Verdict

Do not merge as-is. This patch represents a different implementation than what was already merged to qcom-next. The FROMLIST prefix suggests this is from an upstream submission, but the substantial differences from the qcom-next version indicate either:

  1. This is a newer upstream revision that supersedes qcom-next, OR
  2. This is an older version that conflicts with qcom-next, OR
  3. The lore link points to a different patch in a series

Required actions:

  1. Verify which version is correct (upstream vs qcom-next)
  2. If this supersedes qcom-next, the commit message must explain the changes and reference the previous commit
  3. Remove unrelated uart0 enablement to separate commit
  4. Clarify authorship and email address changes
  5. Verify the lore link actually matches this patch (network was restricted during validation)

Final Summary

  1. Lore link present: Yes — Link tag points to lore.kernel.org message-ID
  2. Lore link matches PR commits: Cannot verify — network restricted; lore.kernel.org unreachable during validation
  3. Upstream patch status: Unknown — cannot fetch from lore due to network restrictions
  4. PR present in qcom-next: No — but a related commit 9896f69f0a12 exists with same feature but significantly different implementation

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28463550718

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No binding changes in this PR
dtb-check Failed to match schema for lontium,lt9611uxd
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit allowed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28463550718

Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No binding changes in this PR
dtb-check Failed to match schema for lontium,lt9611uxd
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check FROMLIST: prefix present
qcom-next-check FROMLIST: commit allowed

❌ dtb-check

Root cause: The compatible string lontium,lt9611uxd is used in the device tree but has no corresponding YAML schema binding in Documentation/devicetree/bindings/.

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

Fix:

This PR adds device tree support for the LT9611UXD HDMI-DSI bridge but does not include the corresponding device tree binding documentation. To fix this:

  1. Add the YAML binding schema for lontium,lt9611uxd in Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml (or similar path)
  2. Ensure the binding is merged upstream first before the DTS changes, or include it in the same patch series
  3. Check the lore link (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/) to verify if the binding was submitted in an earlier patch in the series

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-iqs-evk.dtb

⚠️ checkpatch

Root cause: The compatible string lontium,lt9611uxd appears in the DTS but checkpatch cannot find its documentation.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented -- check ./Documentation/devicetree/bindings/
#71: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:489:
+		compatible = "lontium,lt9611uxd";

Fix:

This is the same root cause as the dtb-check failure. Once the device tree binding YAML schema is added to Documentation/devicetree/bindings/, this warning will be resolved.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git HEAD~1..HEAD

Verdict

2 blockers to fix: This PR cannot be merged until the device tree binding documentation for lontium,lt9611uxd is added. The patch appears to be part 5 of a series (based on the lore link). Verify that patches 1-4 in the upstream series include the binding documentation, and ensure those are merged first or included in this PR.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ◻️ ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ◻️ ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants