wifi: ath12k: fix rx_mpdu_start layout for QCC2072

[张伟 (WeiZhang-stone)]

QCC2072's rx_mpdu_start TLV has a different field layout from QCN9274. Reusing struct rx_mpdu_start_qcn9274 in hal_rx_desc_qcc2072 causes the RX datapath to read the wrong offsets for info2, info4, pn[] and phy_ppdu_id, producing corrupted sequence number, PN, ppdu_id and mpdu-info flags (encrypted, fragment, addr2/addr4 valid).

Add a dedicated struct rx_mpdu_start_qcc2072 that matches the actual hardware descriptor layout, and use it in hal_rx_desc_qcc2072.

CRs-Fixed: 4558487

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4558487 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4558487

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #779 — validate-patch

PR: #779

Verdict	Issues	Detailed Report
⚠️	1	Full report

Final Summary

1. Lore link present: Yes — Link: tag with linux-wireless message-ID included
2. Lore link matches PR commits: N/A — lore.kernel.org returns empty; patch appears freshly posted or link is premature
3. Upstream patch status: In review — FROMLIST: prefix indicates pending upstream submission; lore link not yet accessible
4. PR present in qcom-next: Not checked — validation scope limited to commit message and diff structure per instructions

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #779 - wifi: ath12k: fix rx_mpdu_start layout for QCC2072
Upstream commit: https://lore.kernel.org/linux-wireless/20260629061529.1993932-1-wei.zhang@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Lore link not yet accessible; patch appears freshly posted
Body preserves rationale	✅	Clear problem statement and solution description
Fixes tag present/correct	✅	Fixes: 28badc7 with proper format and subject
Authorship preserved	✅	Wei Zhang wei.zhang@oss.qualcomm.com
Backport note (if applicable)	N/A	FROMLIST prefix indicates pending upstream submission

Diff

File	Status	Notes
drivers/net/wireless/ath/ath12k/wifi7/hal_rx_desc.h	✅	Adds new struct rx_mpdu_start_qcc2072 and updates hal_rx_desc_qcc2072

Issues

• Lore link timing: The Link: tag references a message-ID dated 2026-06-29 06:15:29, but the lore.kernel.org URL returns empty content, suggesting the patch was either just posted or the link is premature. The FROMLIST: prefix is appropriate for patches pending upstream review.

Verdict

Patch structure and commit message follow kernel conventions correctly; FROMLIST prefix is appropriate; cannot verify diff faithfulness to upstream until lore link becomes accessible.

Final Summary

1. Lore link present: Yes — Link: tag with linux-wireless message-ID included
2. Lore link matches PR commits: N/A — lore.kernel.org returns empty; patch appears freshly posted or link is premature
3. Upstream patch status: In review — FROMLIST: prefix indicates pending upstream submission; lore link not yet accessible
4. PR present in qcom-next: Not checked — validation scope limited to commit message and diff structure per instructions

[qlijarvis]

PR #779 — checker-log-analyzer

PR: #779
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28358565913

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: long Tested-on line, unknown commit in Fixes tag
dt-binding-check	✅	No DT binding changes
dtb-check	✅	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	✅	Passed
tag-check	⏭️	N/A (not qcom-next/qcom-next-staging)
qcom-next-check	⏭️	N/A (target branch: qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #779 - FROMLIST: wifi: ath12k: fix rx_mpdu_start layout for QCC2072
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28358565913

Checker	Result	Summary
checkpatch	❌	2 warnings: long Tested-on line, unknown commit in Fixes tag
dt-binding-check	✅	No DT binding changes
dtb-check	✅	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	✅	Passed
tag-check	⏭️	N/A (not qcom-next/qcom-next-staging)
qcom-next-check	⏭️	N/A (target branch: qcom-6.18.y)

❌ checkpatch

Root cause: Two checkpatch warnings triggered by commit message formatting

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#15: 
Tested-on: QCC2072 hw1.0 PCI WLAN.COL.1.0.c2-00188-QCACOLSWPL_V1_TO_SILICONZ-1

WARNING: Unknown commit id '28badc78142e', maybe rebased or not pulled?
#17: 
Fixes: 28badc78142e ("wifi: ath12k: add HAL descriptor and ops for QCC2072")

Analysis:

1. Long Tested-on line (81 chars): The Tested-on: tag exceeds the recommended 75-character limit by 6 characters. This is a minor style issue and is commonly accepted in wireless driver patches where hardware identifiers are long.

2. Unknown commit in Fixes tag: The commit 28badc78142e referenced in the Fixes: tag is not present in the qcom-6.18.y baseline branch. This warning occurs because:

   • The commit being fixed may exist in a different branch (e.g., upstream or a topic branch)
   • The commit may not have been merged into qcom-6.18.y yet
   • This is a false positive if the commit exists in the integration tree or will be present when this PR is merged

Fix:

Option 1 (Recommended): Accept both warnings as non-blocking

• The long Tested-on line is standard practice for ath12k patches with long firmware version strings
• The unknown commit warning is expected when the Fixes: tag references a commit not yet in the target branch
• Both warnings are informational and do not indicate actual code issues

Option 2: Wrap the Tested-on line (if strictly enforcing 75-char limit)

Tested-on: QCC2072 hw1.0 PCI
  WLAN.COL.1.0.c2-00188-QCACOLSWPL_V1_TO_SILICONZ-1

Option 3: Verify the Fixes tag

• Confirm that commit 28badc78142e exists in the upstream or integration tree
• If it doesn't exist in qcom-6.18.y, consider whether the Fixes: tag is necessary for this branch

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..daa4615969c8c32b6834027eb9aad8a3cd2a57b0

Verdict

1 non-blocking issue - The checkpatch warnings are minor and commonly accepted in wireless driver patches. The Tested-on line length is standard for ath12k, and the unknown commit warning is expected when the Fixes: tag references a commit not yet in the target branch. All other checkers passed. Recommend merge with maintainer discretion on the checkpatch warnings.