FROMLIST: soundwire: qcom: Add set_channel_map support to SWR master DAI#783
Open
mohsRafi wants to merge 1 commit into
Open
FROMLIST: soundwire: qcom: Add set_channel_map support to SWR master DAI#783mohsRafi wants to merge 1 commit into
mohsRafi wants to merge 1 commit into
Conversation
Add .set_channel_map support to the SWR master DAI so the ASoC layer can program per-port channel masks used by port_enable(). Fix several issues in channel map handling: clip programming to available ports to avoid out-of-bounds access, use 1-based port indexing, and store TX/RX masks separately. Also track per-direction validity and select the effective mask based on port role to avoid incorrect precedence and ensure full-width masks are preserved. Fall back to the SDW stream-provided channel mask when no mapping is configured, preserving existing behaviour. Link: https://lore.kernel.org/all/20260629141633.86657-3-mohammad.rafi.shaik@oss.qualcomm.com/ Fixes: 7796c97 ("soundwire: qcom: Add set_channel_map api support") Reported-by: Yongqin Liu <yongqin.liu@linaro.org> Closes: https://lore.kernel.org/all/4ddd6855-3817-4dc4-81c4-d8ddaa039865@oss.qualcomm.com/ Reported-by: Jie Gan <jie.gan@oss.qualcomm.com> Closes: https://lore.kernel.org/all/CAMSo37U1kJq_gK8jiW9iMbhHXtn=Chr7NawiK4fPUPj4kyqH2w@mail.gmail.com/ Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/33fe8fe7-719a-405a-9ed2-d9f816ce1d57@sabinyo.mountain/ Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
mohsRafi
requested review from
a team,
Komal Bajaj (Komal-Bajaj),
Kaushal Kumar (quic-kaushalk) and
Salendarsingh Gaud (sgaud-quic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .set_channel_map support to the SWR master DAI so the ASoC layer can program per-port channel masks used by port_enable().
Fix several issues in channel map handling: clip programming to available ports to avoid out-of-bounds access, use 1-based port indexing, and store TX/RX masks separately. Also track per-direction validity and select the effective mask based on port role to avoid incorrect precedence and ensure full-width masks are preserved. Fall back to the SDW stream-provided channel mask when no mapping is configured, preserving existing behaviour.
Link: https://lore.kernel.org/all/20260629141633.86657-3-mohammad.rafi.shaik@oss.qualcomm.com/
CRs-Fixed: 4590627