FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log

[xiuzhuo-shang]

Firmware version is critical for bug triage. Users reporting issues typically share dmesg output rather than debugfs contents, requiring extra communication rounds to collect this information. Log the FW build version directly to the kernel log so it is immediately available in bug reports.

Example output:
Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1

Acked-by: Bartosz Golaszewski bartosz.golaszewski@oss.qualcomm.com

Link: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=559cab24b04e

Link: https://lore.kernel.org/all/809ea8e8-c95e-4200-8d2f-1a0354cd523c@molgen.mpg.de/

CRs-Fixed: 4570456

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4570456 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4570456
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #787 — validate-patch

PR: #787

Verdict	Issues	Detailed Report
⚠️	2	Full report

Final Summary

1. Lore link present: No — FROMGIT: prefix indicates upstream origin, but no Link: tag provided (required for FROMGIT patches)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — could not verify in mainline/bluetooth-next due to network restrictions; FROMGIT prefix suggests it should exist upstream
4. PR present in qcom-next: Yes — commit c8f5ae9 already merged to origin/qcom-next

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #787 - FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log
Upstream commit: Not found in mainline/bluetooth-next (FROMGIT prefix present but no Link: tag)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	✅	Identical to qcom-next commit c8f5ae9
Body preserves rationale	✅	Complete rationale with example output preserved
Fixes tag present/correct	N/A	Not a fix; no Fixes: tag expected
Authorship preserved	✅	Author: Xiuzhuo Shang xiuzhuo.shang@oss.qualcomm.com
Backport note (if applicable)	⚠️	FROMGIT prefix present but missing Link: tag to upstream source

Diff

File	Status	Notes
drivers/bluetooth/btqca.c:143	✅	Identical change: adds bt_dev_info() call with QCA FW build version

Issues

• Missing Link: tag: Patch has FROMGIT: prefix indicating it was picked from an upstream git tree, but lacks the mandatory Link: tag pointing to the lore.kernel.org message-ID or upstream commit. This is required for FROMGIT/UPSTREAM patches per kernel contribution guidelines.
• Upstream verification incomplete: Could not locate the original upstream commit in mainline, bluetooth-next, or lore.kernel.org due to network restrictions. The FROMGIT prefix suggests this should exist upstream, but verification was not possible.

Verdict

Merge with caution — The code change is correct and matches qcom-next commit c8f5ae9. However, the commit message should include a Link: tag pointing to the upstream source (lore message-ID or commit SHA) to properly document the FROMGIT provenance. Request the author to add the Link: tag before merging.

Final Summary

1. Lore link present: No — FROMGIT: prefix indicates upstream origin, but no Link: tag provided (required for FROMGIT patches)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — could not verify in mainline/bluetooth-next due to network restrictions; FROMGIT prefix suggests it should exist upstream
4. PR present in qcom-next: Yes — commit c8f5ae9 already merged to origin/qcom-next

[qlijarvis]

PR #787 — checker-log-analyzer

PR: #787
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28427232305

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Line length warning in commit message example
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing 'Link:' tag in commit message
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #787 - FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28427232305

Checker	Result	Summary
checkpatch	❌	Line length warning in commit message example
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing 'Link:' tag in commit message
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

---

❌ checkpatch

Root cause: Commit message contains an example log line exceeding 75 characters

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14: 
Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1

56d03802ae97b217a5e51295c4224942e4e327ab total: 0 errors, 1 warnings, 0 checks, 8 lines checked

Fix: This is a false positive that can be safely ignored. The warning is triggered by the example output line in the commit message:

Example output:
Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1

This is legitimate example output showing what the patch produces, not prose that should be wrapped. The actual commit message prose is properly formatted. No action required.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git bf153443310432b08d0fece8aad2d9fa1bd9f0f1..56d03802ae97b217a5e51295c4224942e4e327ab

---

❌ check-patch-compliance

Root cause: Commit message is missing the required Link: tag

Failure details:

Checking commit: FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log
No 'Link' found in commit message

Fix: Add a Link: tag pointing to the upstream commit or mailing list discussion. For a FROMGIT: commit, this should reference the commit in the upstream tree it was cherry-picked from.

The commit message should include a line like:

Link: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=<commit-sha>

or

Link: https://lore.kernel.org/linux-bluetooth/<message-id>

Place the Link: tag after the commit description and before the Signed-off-by: tags, following kernel conventions.

Reproduce locally:

git log --format=fuller 56d03802ae97b217a5e51295c4224942e4e327ab -1 | grep -i "^Link:"

---

Verdict

2 blockers to fix:

1. Critical: Add the missing Link: tag to satisfy check-patch-compliance
2. Non-blocking: The checkpatch warning is a false positive and can be ignored

The Link: tag is mandatory for FROMGIT/UPSTREAM commits in the Qualcomm kernel workflow. Once added, the PR will pass all applicable checkers.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4570456 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4570456
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #787 — validate-patch

PR: #787

Verdict	Issues	Detailed Report
⚠️	2	Full report

Final Summary

1. Lore link present: No — FROMGIT: prefix present but no Link: tag in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: In upstream tree — commit exists in qcom-next (c8f5ae9); likely pulled from bluetooth-next but not yet in mainline
4. PR present in qcom-next: Yes — commit c8f5ae9 is present in origin/qcom-next

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #787 - Bluetooth: qca: Add BT FW build version to kernel log
Upstream commit: Present in qcom-next (c8f5ae9), no lore link found
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	✅	Identical to qcom-next commit
Body preserves rationale	✅	Full rationale and example output preserved
Fixes tag present/correct	N/A	Not a fix; no Fixes tag expected
Authorship preserved	✅	Author and date match qcom-next (Xiuzhuo Shang, 2026-06-09)
Backport note (if applicable)	N/A	FROMGIT prefix present; not a backport

Diff

File	Status	Notes
drivers/bluetooth/btqca.c:143	✅	Identical to qcom-next c8f5ae9; adds bt_dev_info log line

Issues

• Missing Link: tag: Commit has FROMGIT: prefix indicating upstream origin, but neither the PR patch nor the qcom-next version (c8f5ae9) includes a Link: tag pointing to the lore.kernel.org discussion. FROMGIT commits should reference the upstream source.
• Lore link not found: Searched lore.kernel.org for this patch by subject and author but could not locate the upstream posting. This may indicate the patch is still in a maintainer tree (bluetooth-next) and not yet posted to LKML, or the search failed to locate it.

Verdict

Diff is faithful to qcom-next; commit message and authorship are correct. However, the missing Link: tag violates FROMGIT conventions. If this patch was pulled from bluetooth-next or another upstream tree, a Link: tag should be added pointing to the commit in that tree or the lore discussion.

Final Summary

1. Lore link present: No — FROMGIT: prefix present but no Link: tag in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: In upstream tree — commit exists in qcom-next (c8f5ae9); likely pulled from bluetooth-next but not yet in mainline
4. PR present in qcom-next: Yes — commit c8f5ae9 is present in origin/qcom-next

[qlijarvis]

PR #787 — checker-log-analyzer

PR: #787
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28435280815

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	✅	Passed (no new warnings introduced)
check-uapi-headers	✅	No changes to UAPI headers
check-patch-compliance	❌	Missing 'Link:' tag in commit message
tag-check	✅	FROMGIT prefix present
qcom-next-check	✅	FROMGIT commit compliant

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #787 - FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28435280815

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	✅	Passed (no new warnings introduced)
check-uapi-headers	✅	No changes to UAPI headers
check-patch-compliance	❌	Missing 'Link:' tag in commit message
tag-check	✅	FROMGIT prefix present
qcom-next-check	✅	FROMGIT commit compliant

❌ check-patch-compliance

Root cause: The commit message is missing a mandatory Link: tag pointing to the upstream source.

Failure details:

2026-06-30T10:01:10.5046307Z Checking commit: FROMGIT: Bluetooth: qca: Add BT FW build version to kernel log
2026-06-30T10:01:10.5079951Z No 'Link' found in commit message
2026-06-30T10:01:10.5097375Z ##[error]Process completed with exit code 1.

Fix: Add a Link: tag to the commit message pointing to the upstream patch on lore.kernel.org or the git tree where this patch was pulled from. The tag should be placed after the Signed-off-by: trailer(s) and before any other tags.

For FROMGIT commits, the Link should point to:

• The lore.kernel.org message-ID URL of the upstream patch, OR
• The git commit URL in the upstream tree (e.g., git.kernel.org or a maintainer tree)

Example format:

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
Link: https://lore.kernel.org/linux-bluetooth/20260609052805.12345-1-xiuzhuo.shang@oss.qualcomm.com/

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base bf153443310432b08d0fece8aad2d9fa1bd9f0f1 --head cd6cc1de0de8b0c163ba03e33f845dcb3dba45ef

Verdict

1 blocker to fix: The commit message must include a Link: tag pointing to the upstream source. Once added, the PR will be ready to merge.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4570456 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4570456
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4570456 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4570456
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.