Skip to content

QCLINUX: arm64: qcom.config: Enable VCAN support#800

Open
q-AnupKulkarni wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
q-AnupKulkarni:rtss_can_linux
Open

QCLINUX: arm64: qcom.config: Enable VCAN support#800
q-AnupKulkarni wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
q-AnupKulkarni:rtss_can_linux

Conversation

@q-AnupKulkarni

@q-AnupKulkarni q-AnupKulkarni commented Jul 1, 2026

Copy link
Copy Markdown

Enable Virtual-CAN(VCAN) support to support RTSS based CAN module from user-space.

CRs-Fixed: 4592789

Enable Virtual-CAN(VCAN) support to support RTSS based CAN
module from user-space.

Signed-off-by: q-AnupKulkarni <anupkulk@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4592789 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4592789
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #800 — validate-patch

PR: #800

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: No — commit 3ce0aa9 not found in /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #800
Title: QCLINUX: arm64: qcom.config: Enable VCAN support
Upstream commit: N/A (vendor-only change)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit; no upstream equivalent
Body preserves rationale Clear rationale: "Enable Virtual-CAN(VCAN) support to support RTSS based CAN module from user-space"
Fixes tag present/correct N/A Not a fix; new feature enablement
Authorship preserved Author: q-AnupKulkarni anupkulk@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/qcom.config Adds 4 lines: comment + CONFIG_CAN=y + CONFIG_CAN_DEV=y + CONFIG_CAN_VCAN=m

Issues

None. This is a clean vendor-only config change.

Verdict

Merge as-is. This is a well-formed vendor-only commit that enables Virtual CAN support in the Qualcomm kernel config. The commit message clearly states the purpose (RTSS-based CAN module support from user-space), the diff is minimal and focused, and the QCLINUX: prefix correctly signals this is not intended for upstream.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: No — commit 3ce0aa9 not found in /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel

@qlijarvis

Copy link
Copy Markdown

PR #800 — checker-log-analyzer

PR: #800
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28498536948

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #800 - QCLINUX: arm64: qcom.config: Enable VCAN support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28498536948

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Commit subject uses "QCLINUX:" prefix which is not a recognized upstream compliance prefix.

Failure details:

2026-07-01T06:51:51.7308039Z Checking commit: QCLINUX: arm64: qcom.config: Enable VCAN support
2026-07-01T06:51:51.7322987Z Commit summary does not start with a required prefix
2026-07-01T06:51:51.7337843Z ##[error]Process completed with exit code 1.

Fix: Remove the "QCLINUX:" prefix from the commit subject. For Qualcomm-specific configuration changes that are not from upstream, the subject should follow standard kernel conventions without special prefixes. The commit subject should be:

arm64: qcom.config: Enable VCAN support

Alternatively, if this change is being prepared for upstream submission, use the appropriate prefix:

  • FROMLIST: - if the patch is posted to a mailing list but not yet merged
  • UPSTREAM: - if the patch is already merged in mainline/upstream
  • BACKPORT: - if backporting an upstream commit to an older kernel

Reproduce locally:

cd /path/to/kernel
git log -1 --format=%s HEAD
# Should not start with QCLINUX: for compliance

Verdict

1 blocker to fix: Remove the "QCLINUX:" prefix from the commit subject. The patch is otherwise clean (checkpatch passed, no code quality issues). After fixing the subject line, the PR will be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants