QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins

[mvadlama-lab]

Swap reset and power down pins for MIPI camera

CRs-Fixed: 4593671

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4391452 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4391452

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4593671 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4593671
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #802 — validate-patch

PR: #802

Verdict	Issues	Detailed Report
⚠️	8	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #802 - QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
Upstream commit: N/A (vendor-only QCLINUX patch)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit; no upstream reference
Body preserves rationale	⚠️	Minimal explanation; lacks hardware context or reason for swap
Fixes tag present/correct	⚠️	No Fixes tag; unclear if this corrects a prior error
Authorship preserved	✅	Author and sign-off present and consistent
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/monaco-evk-camera-sensor.dtsi	✅	Consistent swap across 9 camera sensor nodes

Issues

Commit Message Quality:

• The commit body states "Swap reset and power down pins for MIPI camera" but provides no context about:
  • Why the swap is needed (hardware bug? schematic correction? driver requirement change?)
  • Impact of the change (does this fix a camera initialization failure? power sequencing issue?)
  • Which hardware is affected (Monaco EVK revision? specific camera module?)
• Missing Fixes: tag if this corrects a prior commit that had the pins in wrong order
• For a hardware-critical change like GPIO pin assignment, the rationale should be explicit

Diff Correctness:

• The patch consistently swaps the second and third GPIO entries across all 9 affected camera sensor nodes
• Before: <&tlmm 73/74/75 0>, <&expander2 0/1/2 0>
• After: <&expander2 0/1/2 0>, <&tlmm 73/74/75 0>
• The gpio-reset = <1> and gpio-custom1 = <2> assignments remain unchanged, meaning:
  • Index 1 (previously tlmm 73/74/75) is still marked as reset
  • Index 2 (previously expander2) is still marked as custom1
• This is semantically incorrect: if the physical pins are being swapped, the gpio-reset and gpio-custom1 indices should also be updated to reflect which physical pin serves which function

Verdict

Do not merge as-is. The diff appears to swap GPIO array entries but does not update the corresponding gpio-reset and gpio-custom1 index assignments, which will cause the driver to control the wrong physical pins. The commit message also lacks sufficient rationale for a hardware-critical change.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

[qlijarvis]

PR #802 — checker-log-analyzer

PR: #802
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28516730835

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	No new DTB errors introduced
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #802 - QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28516730835

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	No new DTB errors introduced
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

❌ check-patch-compliance

Root cause: Commit subject starts with "QCLINUX:" which is not a recognized upstream compliance prefix.

Failure details:

2026-07-01T12:30:53.3167907Z Checking commit: QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
2026-07-01T12:30:53.3183819Z Commit summary does not start with a required prefix
2026-07-01T12:30:53.3199654Z ##[error]Process completed with exit code 1.

Fix:

The commit subject must start with one of the following prefixes to indicate upstream tracking status:

• UPSTREAM: - For patches already merged in mainline Linux
• FROMLIST: - For patches posted to upstream mailing lists but not yet merged
• BACKPORT: - For patches backported from a newer kernel version
• FROMGIT: - For patches pulled from a maintainer's git tree

For this internal device tree change that swaps GPIO pin assignments for the Monaco EVK camera sensor, the appropriate prefix depends on the upstream status:

1. If this change has been posted to the Linux kernel mailing list (devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org), use:

   FROMLIST: arm64: dts: qcom: Swap RESET and POWER down pins
   

2. If this is a downstream-only change not intended for upstream, remove the "QCLINUX:" prefix entirely and use standard kernel commit format:

   arm64: dts: qcom: monaco-evk: Swap camera RESET and PWDN pins
   

Reproduce locally:

# Clone the kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run the compliance checker
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel \
  --base 483a4490aadd7c75ef84303b5d28387e5848208c \
  --head 2f83f6178b59421d41c53965571cb5e14055f352

Verdict

1 blocker to fix: The commit subject must be updated with a valid upstream compliance prefix (UPSTREAM:/FROMLIST:/BACKPORT:/FROMGIT:) or reformatted as a standard kernel commit without the "QCLINUX:" prefix. All other checkers passed successfully.