Skip to content

Report low-confidence Sinter decodes as discards - #300

Open
danielgaskins wants to merge 1 commit into
quantumlib:mainfrom
danielgaskins:fix/sinter-low-confidence
Open

Report low-confidence Sinter decodes as discards#300
danielgaskins wants to merge 1 commit into
quantumlib:mainfrom
danielgaskins:fix/sinter-low-confidence

Conversation

@danielgaskins

Copy link
Copy Markdown

Summary

  • append Sinter's discard byte to compiled decoder results
  • set the discard byte when Tesseract reports low confidence
  • document errors + discards as the conservative logical failure count
  • add direct-output and Sinter-sampler regression tests

This addresses the compiled-decoder portion of #297. The pinned Sinter file-decoder API reads exactly the observable bytes for each shot and has no decoder-controlled discard channel, so decode_via_files remains unchanged. The multipass decoder in #256 will need equivalent propagation when it is integrated.

Testing

  • clang-format --dry-run --Werror src/tesseract_sinter_compat.pybind.h
  • focused low-confidence tests: 2 passed
  • bazel test --jobs=1 //src/...: 12 of 13 targets passed; the pre-existing unseeded test_sinter_decode_surface_code exceeded its statistical threshold locally

@danielgaskins

Copy link
Copy Markdown
Author

Could someone with Actions access rerun the failed jobs? The macOS failure came from the existing unseeded test_sinter_decode_surface_code statistical threshold. The new deterministic discard tests passed, as did formatting and all wheel builds.

@mhucka

mhucka commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Could someone with Actions access rerun the failed jobs? The macOS failure came from the existing unseeded test_sinter_decode_surface_code statistical threshold. The new deterministic discard tests passed, as did formatting and all wheel builds.

Done. FYI that I had to rerun it twice, actually; the first rerun saw macos succeed but linux fail; the second rerun saw the linux tests succeed. (Mentioning it in case this is useful for additional development.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants