Report low-confidence Sinter decodes as discards - #300
Open
danielgaskins wants to merge 1 commit into
Open
Conversation
Author
|
Could someone with Actions access rerun the failed jobs? The macOS failure came from the existing unseeded |
Contributor
Done. FYI that I had to rerun it twice, actually; the first rerun saw macos succeed but linux fail; the second rerun saw the linux tests succeed. (Mentioning it in case this is useful for additional development.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors + discardsas the conservative logical failure countThis addresses the compiled-decoder portion of #297. The pinned Sinter file-decoder API reads exactly the observable bytes for each shot and has no decoder-controlled discard channel, so
decode_via_filesremains unchanged. The multipass decoder in #256 will need equivalent propagation when it is integrated.Testing
clang-format --dry-run --Werror src/tesseract_sinter_compat.pybind.hbazel test --jobs=1 //src/...: 12 of 13 targets passed; the pre-existing unseededtest_sinter_decode_surface_codeexceeded its statistical threshold locally