Skip to content

verify-package-attribution.sh: respect CARGO_TARGET_DIR - #21

Merged
alexy merged 1 commit into
mainfrom
fix/attribution-respects-target-dir
Sep 20, 2026
Merged

alexy merged 1 commit into
mainfrom
fix/attribution-respects-target-dir

Conversation

@alexy

@alexy alexy commented Sep 20, 2026

Copy link
Copy Markdown
Member

scripts/ci-local.sh run with CARGO_TARGET_DIR set fails its last gate:

==> Third-party package attribution
missing packaged facade archive: target/package/grust-graph-0.21.0.crate

cargo package had succeeded and written the archive to the configured target directory; only this script's hardcoded target/package/... was wrong. Found on eigen, where each gate worktree gets its own target directory so that concurrent gates do not share one.

One line: target=${CARGO_TARGET_DIR:-target}. Unchanged for anyone who does not set the variable, which is why neither Linux host hit it.

🤖 Generated with Claude Code

A gate that gives each worktree its own target directory packaged the facade
successfully and then failed the attribution gate, because the script looked
only in ./target. Found running ci-local.sh on eigen.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
alexy added a commit that referenced this pull request Sep 20, 2026
Main passed every gate at cf7e2a4. At posting time main is ff9524d and the only
code that moved is ci-local.sh, which is #19 merging and carries its own verdict
from this host, so main code is verified as of this line.

Notes that scripts/ will match on every CI merge, so the recheck wants reading
rather than a clean-or-dirty answer. G5 started on PR #21.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@alexy

alexy commented Sep 20, 2026

Copy link
Copy Markdown
Member Author
ci-local: PASSED every gate at d499128 on Linux x86_64 in 1855s

Host grust (Linux x86_64), full gates, own detached worktree at the branch head. Code drift check at posting time: main is 61cf996 and the only file differing from this branch under crates/, benchmarks/ or scripts/ is verify-package-attribution.sh itself, which is this PR.

What this verdict does not cover. The bug #21 fixes appears only when CARGO_TARGET_DIR is set, and this host isolates by worktree rather than by target directory, so the run never set it. The gate therefore shows the change does not break the ordinary path; it does not exercise the condition being repaired. The one-line change reads correctly by inspection (target=${CARGO_TARGET_DIR:-target}), and if you want the repaired path proven I can rerun here with CARGO_TARGET_DIR set — say the word.

This is G5 from task board #5.

alexy added a commit that referenced this pull request Sep 20, 2026
PR #21 passed every gate at d499128. The verdict states what it does not cover:
the bug needs CARGO_TARGET_DIR set and this host isolates by worktree instead.

G5 package gate again resolved every sibling from tmp-registry with no crates.io
lookups, matching G0, which makes the host difference environmental and supports
the cached-tarball explanation for quegee failure.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@alexy
alexy merged commit 309c34e into main Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant