Dampen readiness flaps#6559
Open
shuheiktgw wants to merge 1 commit into
Open
Conversation
guilload
approved these changes
Jun 29, 2026
| let mut failures_to_inject = metastore_failures_to_inject_clone.lock().unwrap(); | ||
| if *failures_to_inject > 0 { | ||
| *failures_to_inject -= 1; | ||
| return Err(anyhow::anyhow!("Metastore transiently not ready")); |
Member
There was a problem hiding this comment.
Suggested change
| return Err(anyhow::anyhow!("Metastore transiently not ready")); | |
| bail!(...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dampen node readiness flaps by requiring 3 consecutive failed readiness checks before advertising
NOT_READY. Successful checks still restore readiness immediately.