Strip ANSI from the target of {.url} hyperlinks - #845
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With hyperlinks enabled,
{.url}containing a substitution puts ANSI escapes into the link target:The target was
https://example.com/\033[3mpath\033[3m, because the substituted value is italicised by the.urlstyle before the whole string is passed to the link builder. Clicking it openshttps://example.com/%1B%5B3mpath%1B%5B3m.make_link_url()now strips ANSI from the target. The displayed text is unchanged, and so is the output for{.url}without substitutions, vectors, already-linked values, and with hyperlinks off.Closes #757