Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli_progress_output()errors with "attempt to apply non-function" under the Shiny progress handler when the bar hasn't been shown yet:(with
options(cli.progress_handlers_only = "shiny"); in a real app the handler is picked automatically.)Bars are only added after
cli.progress_show_after(2 seconds by default), and the handler'soutput()method calledbar$shiny_progress$set(), butshiny_progressis only created inadd(). So any output sent before that point hitsNULL$set().output()still records the text inbar$shiny_output, so it shows up once the bar is added; it just doesn't callset()until there is a Shiny progress object.The new test in
test-progress-handlers.Rfails on main and passes here. I also tried output before and after the bar is shown, several outputs,cli_progress_message(),cli_progress_step()and finishing before the bar is ever shown; only the calls that used to error behave differently. The only failures in the full suite locally are thekeypress()tests, which fail the same way on main.I added
shinyto Suggests for the test.Closes #762