Skip to content

fix(neutron-understack): guard removal of segment to those that exist #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardoe merged 1 commit into from
Jul 28, 2026
+6 −8
Merged

fix(neutron-understack): guard removal of segment to those that exist #2168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions python/neutron-understack/neutron_understack/trunk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from neutron.objects.network import NetworkSegment
from neutron.objects.ports import Port
from neutron.objects.ports import PortBindingLevel
from neutron.objects.trunk import SubPort
from neutron.services.trunk.drivers import base as trunk_base
from neutron.services.trunk.models import Trunk
Expand Down Expand Up @@ -223,11 +222,6 @@ def _clean_parent_port_switchport_config(
vlan_group_name=vlan_group_name,
)

def _delete_binding_level(self, port_id: str, host: str) -> PortBindingLevel:
binding_level = utils.port_binding_level_by_port_id(port_id, host)
binding_level.delete()
return binding_level

def _delete_unused_segment(self, segment_id: str) -> NetworkSegment:
network_segment = utils.network_segment_by_id(segment_id)
if not utils.ports_bound_to_segment(
Expand All @@ -238,8 +232,12 @@ def _delete_unused_segment(self, segment_id: str) -> NetworkSegment:

def _handle_segment_deallocation(self, subports: list[SubPort], host: str):
for subport in subports:
subport_binding_level = self._delete_binding_level(subport["port_id"], host)
self._delete_unused_segment(subport_binding_level.segment_id)
binding_level = utils.port_binding_level_by_port_id(
subport["port_id"], host
)
if binding_level:
binding_level.delete()
self._delete_unused_segment(binding_level.segment_id)

def _handle_subports_removal(
self,
Expand Down
Loading