Skip to content

Use test_bit for RPC_PRIVATE in homa_rpc_get_info #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
randomizedcoder wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use test_bit for RPC_PRIVATE in homa_rpc_get_info #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homa_rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,6 @@ void homa_rpc_get_info(struct homa_rpc *rpc, struct homa_rpc_info *info)
rpc->msgin.bytes_remaining == 0 &&
skb_queue_len(&rpc->msgin.packets) == 0)
info->flags |= HOMA_RPC_RX_READY;
if (rpc->flags & RPC_PRIVATE)
if (test_bit(RPC_PRIVATE, &rpc->flags))
info->flags |= HOMA_RPC_PRIVATE;
}
13 changes: 12 additions & 1 deletion test/unit_homa_rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,7 +1572,18 @@ TEST_F(homa_rpc, homa_rpc_get_info__HOMA_RPC_PRIVATE)
self->server_port, self->client_id, 5000, 20000);
struct homa_rpc_info info;

crpc->flags |= RPC_PRIVATE;
set_bit(RPC_PRIVATE, &crpc->flags);
homa_rpc_get_info(crpc, &info);
EXPECT_EQ(HOMA_RPC_PRIVATE, info.flags);
}
TEST_F(homa_rpc, homa_rpc_get_info__APP_NEEDS_LOCK_is_not_private)
{
struct homa_rpc *crpc = unit_client_rpc(&self->hsk,
UNIT_OUTGOING, self->client_ip, self->server_ip,
self->server_port, self->client_id, 5000, 20000);
struct homa_rpc_info info;

set_bit(APP_NEEDS_LOCK, &crpc->flags);
homa_rpc_get_info(crpc, &info);
EXPECT_EQ(0, info.flags);
}