Repository navigation
vcgencmd: document pmic_read_adc, fix command heading levels - #4330
Closed
manunicholasjacob wants to merge 1 commit into
Closed
manunicholasjacob wants to merge 1 commit into
manunicholasjacob wants to merge 1 commit into
Conversation
Add a pmic_read_adc [channel] entry with output captured on a Raspberry Pi 5, note that measure_temp pmic also works on Raspberry Pi 5, and note that mem_oom and mem_reloc_stats are not registered on Raspberry Pi 5. codec_enabled, mem_oom, mem_reloc_stats and read_ring_osc used level 5 headings, so they rendered as sub-sections of get_mem. Move them to level 4 like the other vcgencmd commands.
Contributor
|
Thank you for this contribution, Manu. I will talk to the engineers and incorporate it into the main documentation if they approve it. |
Contributor
|
Now transferred to our internal repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vcgencmd section is missing
pmic_read_adc, althoughvcgencmd commandslists it on Raspberry Pi 5 and the power supply and overclocking pages already tell readers to run it. This PR:pmic_read_adc [channel]entry with real output and a link to "Power supplies and Raspberry Pi OS"measure_temp pmicalso works on Raspberry Pi 5 (the text said Raspberry Pi 4 only)mem_oomandmem_reloc_statsare not available on Raspberry Pi 5 (both returnerror=1 error_msg="Command not registered", and neither is invcgencmd commands)codec_enabled,mem_oom,mem_reloc_statsandread_ring_oscfrom=====to====, so they no longer render as sub-sections ofget_memAll outputs were captured on a Raspberry Pi 5 Model B Rev 1.0, firmware 2025/03/19
cec1d3ae:vcgencmd pmic_read_adcprints 26 lines (12 currents, 14 voltages);vcgencmd pmic_read_adc EXT5V_Vprints one linevcgencmd pmic_read_adc bogusprints all 26 channels and exits 0, which is why the entry mentions that an unrecognised name lists every channelvcgencmd measure_temp pmicreturnstemp=41.6'C(SoCtemp=43.3'C)Build:
makeon Ubuntu (WSL2) following CONTRIBUTING.md, before and after the change, with no new warnings. In the generatedcomputers/os.html, all 14 commands undervcgencmdare nowh4(before, the last four wereh5), and the new cross-link resolves toraspberry-pi.html#power-supplies-and-raspberry-pi-os.scripts/check_line_endings.pypasses.I used an AI assistant (Claude) to help draft this change. I checked every statement against the output from my own Raspberry Pi 5.