Fix onboard temperature ADC example for RP2350B - #779
Open
andygpz11 wants to merge 1 commit into
Open
Conversation
Contributor
# in the pico-sdk repo...
$ git grep ADC_TEMPERATURE_CHANNEL_NUM
src/rp2_common/hardware_adc/include/hardware/adc.h:#ifndef ADC_TEMPERATURE_CHANNEL_NUM
src/rp2_common/hardware_adc/include/hardware/adc.h:#define ADC_TEMPERATURE_CHANNEL_NUM (NUM_ADC_CHANNELS - 1)
$ git grep -C2 NUM_ADC_CHANNELS
src/rp2040/hardware_regs/include/hardware/platform_defs.h-#define NUM_ALARMS _u(4)
src/rp2040/hardware_regs/include/hardware/platform_defs.h-#define ADC_BASE_PIN _u(26)
src/rp2040/hardware_regs/include/hardware/platform_defs.h:#define NUM_ADC_CHANNELS _u(5)
src/rp2040/hardware_regs/include/hardware/platform_defs.h-#define NUM_RESETS _u(25)
src/rp2040/hardware_regs/include/hardware/platform_defs.h-#define NUM_BANK0_GPIOS _u(30)
--
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#define NUM_ALARMS _u(4)
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#if PICO_RP2350A
src/rp2350/hardware_regs/include/hardware/platform_defs.h:#define NUM_ADC_CHANNELS _u(5)
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#define ADC_BASE_PIN _u(26)
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#else
src/rp2350/hardware_regs/include/hardware/platform_defs.h:#define NUM_ADC_CHANNELS _u(9)
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#define ADC_BASE_PIN _u(40)
src/rp2350/hardware_regs/include/hardware/platform_defs.h-#endifSo LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing some work on an RP2350B, which has 8 ADC channels, I noticed that this ADC example didn't work due to a hard coded ADC channel.
Use of the appropriate #define should ensure that this works as expected on all RP2x