Skip to content

chore(store): remove the orphaned blob store and its gocloud.dev dependency - #1900

Merged
rohilsurana merged 1 commit into
mainfrom
chore/remove-orphaned-blob-store
Aug 24, 2026
Merged

rohilsurana merged 1 commit into
mainfrom
chore/remove-orphaned-blob-store

Conversation

@rohilsurana

Copy link
Copy Markdown
Member

What

Delete the internal/store/blob package and drop the gocloud.dev dependency.

Why

internal/store/blob had two users: the boot-time resources-config schema loader and the billing plans loader. Both were removed when those flows moved to the declarative reconcile flow (#1767 and #1870). What was left, blob.go and plans/sample.yaml, has no importers, and gocloud.dev was used only by this package.

Verified before removing:

  • rg "internal/store/blob" returns nothing outside the package itself.
  • rg "gocloud.dev" -g '*.go' returns nothing outside blob.go.

Result

  • Removed internal/store/blob/blob.go and internal/store/blob/plans/sample.yaml.
  • go mod tidy dropped gocloud.dev and its transitive Google Cloud tree (cloud.google.com/go/*, google.golang.org/api, s2a-go, google/wire, and others). go.sum shrank by about 2400 lines.
  • go build ./... and go vet ./internal/store/... ./cmd/... both pass.

@vercel

vercel Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview Aug 21, 2026 6:53am

@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 49deb8da-dac9-4d1a-a0ac-c108be737538

📥 Commits

Reviewing files that changed from the base of the PR and between 670a8fe and d49b8d7.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go.mod
  • internal/store/blob/blob.go
  • internal/store/blob/plans/sample.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Removed obsolete dependency requirements and streamlined project dependencies.
  • Refactor

    • Removed legacy blob storage configuration and bucket implementation.
    • Deleted the sample billing plan configuration.
  • Breaking Changes

    • Legacy blob storage functionality and its associated configuration are no longer available.

Walkthrough

The change deletes the blob storage implementation and sample billing plan. It also removes obsolete indirect Go dependencies and adds gotest.tools to go.mod.

Changes

Storage and dependency cleanup

Layer / File(s) Summary
Blob storage removal
internal/store/blob/blob.go
Removes the Bucket interface, NewStore constructor, and storage backends for memory, Google Cloud Storage, and local files.
Sample plan removal
internal/store/blob/plans/sample.yaml
Removes the sample billing plan configuration and its feature, product, pricing, and plan definitions.
Dependency manifest cleanup
go.mod
Removes obsolete cloud, telemetry, Google, protobuf, and auxiliary indirect dependencies. Adds indirect gotest.tools.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: amangit07


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32456196339

Coverage increased (+0.08%) to 48.886%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 40034
Covered Lines: 19571
Line Coverage: 48.89%
Coverage Strength: 15.76 hits per line

💛 - Coveralls

@rohilsurana
rohilsurana marked this pull request as ready for review August 24, 2026 07:28
@rohilsurana
rohilsurana merged commit 6466e39 into main Aug 24, 2026
7 of 8 checks passed
@rohilsurana
rohilsurana deleted the chore/remove-orphaned-blob-store branch August 24, 2026 07:29

This branch was successfully deployed

1 active deployment
Preview — d49b8d7b Deployed Aug 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants