chore(store): remove the orphaned blob store and its gocloud.dev dependency - #1900
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change deletes the blob storage implementation and sample billing plan. It also removes obsolete indirect Go dependencies and adds ChangesStorage and dependency cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 32456196339Coverage increased (+0.08%) to 48.886%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
What
Delete the
internal/store/blobpackage and drop thegocloud.devdependency.Why
internal/store/blobhad two users: the boot-time resources-config schema loader and the billing plans loader. Both were removed when those flows moved to the declarative reconcile flow (#1767 and #1870). What was left,blob.goandplans/sample.yaml, has no importers, andgocloud.devwas used only by this package.Verified before removing:
rg "internal/store/blob"returns nothing outside the package itself.rg "gocloud.dev" -g '*.go'returns nothing outsideblob.go.Result
internal/store/blob/blob.goandinternal/store/blob/plans/sample.yaml.go mod tidydroppedgocloud.devand its transitive Google Cloud tree (cloud.google.com/go/*,google.golang.org/api,s2a-go,google/wire, and others).go.sumshrank by about 2400 lines.go build ./...andgo vet ./internal/store/... ./cmd/...both pass.