Fix removing -O3 on ruby-dev and Ruby < 3.2 on Fedora 42+ - #2638
Merged
Conversation
Exporting CFLAGS overrides Ruby's default optflags/debugflags/warnflags, notably losing -O3 and silently producing a much slower (-O0) Ruby. The cflags configure variable is appended to those defaults instead. Keep prepending to CFLAGS when the user already overrides CFLAGS, since configure ignores cflags when CFLAGS is given. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
"Additional" was misleading: passing CFLAGS to Ruby's configure replaces the default optflags/debugflags/warnflags, so e.g. RUBY_CFLAGS=-march=native silently builds an unoptimized (-O0) Ruby. Document the overriding semantics and point to RUBY_CONFIGURE_OPTS=cflags=... for adding flags. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
normalize_semver("dev") returned 0, so ruby-dev was treated as older
than any released version and version-gated workarounds misfired.
Notably the Fedora 42+ -std=gnu17 workaround for Ruby < 3.2 was
applied to ruby-dev builds, which do not need it.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Great catch; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2637