Repository navigation
Conversation
A field submitted by closing the popup kept its temporary calendar value when the submit was rejected by disabledDate, so the selector displayed a value the committed value never accepted. Blur and Enter also behaved differently for the same input, since Enter's close event arrives one step later and lands on the `currentIndex === null` branch. Let `flushSubmit` report whether the flushed value was accepted, and reset the temporary value inside `submitField` when it was rejected. Consumers that explicitly ask for the typed text to survive blur (`preserveInvalidOnBlur`) keep the previous behaviour.
|
@Ye-YiChen is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough单日期和范围日期选择器现可获知字段提交的校验结果。提交被拒绝时，值变更流程默认重置临时值；启用 Changes被拒绝日期的失焦处理
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to With this change, a date rejected by Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check PR 满足直接关联的开放问题 [ #1018]。useRangeValue的flushSubmit返回业务校验结果。useRangeValueChange.submitField在结果为false且未启用preserveInvalidOnBlur时调用resetValue()，因此失焦提交被disabledDate拒绝时会恢复受控值。`SingleP…Out of Scope Changes check 改动均与 [ #1018] 的提交失败处理相关。RangePicker复用同一提交路径，属于相同问题的相关场景。新增测试验证默认回退、preserveInvalidOnBlur保留和成功提交，没有发现与该问题无关的代码或测试改动。Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check 标题准确概括了主要变更：弹层关闭时丢弃被拒绝的临时值。该描述与代码修改和测试目标一致，且简洁明确。
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
兔子轻敲日期框，
失焦遇拒值归还。
若设保留，字仍在，
获准日期入日历。
新测例中蹦跳欢。
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
1 participant
Fixes #1018
Problem: a date rejected by
disabledDateis not reverted when the input is blurred (the popup closes) — the input keeps showing it while the committedvaluewas never updated. Pressing Enter for the same input works.Why:
resolveActiondecides the action before the submit happens, so it cannot know the submit will be rejected. On the blur path the popup close is what triggers the submit; after the rejectionreset()only clears the bookkeeping and leaves the temporary value behind, andswitchNextis a submit action, so nothing ever reachesresetValue. Enter only works by accident: its close event arrives one step later and lands on thecurrentIndex === nullbranch.Changes
flushSubmitnow reports the submit result (boolean | void), andsubmitFielddiscards the temporary value when it comes backfalse— equivalent to runningresetAllon the spot.preserveInvalidOnBlurkeeps the previous behaviour by skipping that discard (the default is to discard).Tests in
tests/blur.spec.tsx: rejected → reverted, rejected withpreserveInvalidOnBlur→ kept, accepted → committed.One thing to confirm: Does the
preserveInvalidOnBlurprop affectdisabledDate?