Skip to content

perf: Cache normalisedColors output #57896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
riteshshukla04 wants to merge 4 commits into from
+19 −0
Closed

perf: Cache normalisedColors output #57896

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13fd992
perf: Cache the processColors
riteshshukla04 Aug 11, 2026
b156f44
perf: Cache the processColors
riteshshukla04 Aug 11, 2026
5df460e
perf: Cache the processColors
riteshshukla04 Aug 11, 2026
f60c060
re trigger ci
riteshshukla04 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/normalize-color/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

'use strict';

const cachedColors = new Map();

function normalizeColor(color) {
if (typeof color === 'number') {
if (color >>> 0 === color && color >= 0 && color <= 0xffffffff) {
Expand All @@ -24,6 +26,23 @@ function normalizeColor(color) {
return null;
}

if (cachedColors.has(color)) {
// Map iteration order follows insertion order, so re-inserting on every
// hit keeps the least-recently-used entry first.
const cachedColor = cachedColors.get(color);
cachedColors.delete(color);
cachedColors.set(color, cachedColor);
return cachedColor;
}
const normalizedColor = parseColorString(color);
if (cachedColors.size >= 1024) {
cachedColors.delete(cachedColors.keys().next().value);
}
Comment thread
riteshshukla04 marked this conversation as resolved.
cachedColors.set(color, normalizedColor);
return normalizedColor;
}

function parseColorString(color) {
const matchers = getMatchers();
let match;

Expand Down
Loading