Upgrade Modal visibility to "for frameworks" (#58285) - #58285
Open
j-piasecki wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118440328. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Reclassifies `react/renderer/components/modal:modal` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440328
j-piasecki
force-pushed
the
export-D118440328
branch
from
September 3, 2026 07:53
a6f19cf to
8293718
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Reclassifies `react/renderer/components/modal:modal` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440328
j-piasecki
force-pushed
the
export-D118440328
branch
from
September 3, 2026 07:53
8293718 to
e426b31
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#58285 Reclassifies `react/renderer/components/modal:modal` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440328
j-piasecki
force-pushed
the
export-D118440328
branch
from
September 3, 2026 07:56
e426b31 to
a63b770
Compare
Summary: Reclassifies `react/renderer/components/modal:modal` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440328
j-piasecki
force-pushed
the
export-D118440328
branch
from
September 3, 2026 08:03
a63b770 to
ffe6ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reclassifies
react/renderer/components/modal:modalfrom public to "for frameworks" under the C++ stable API three-tier visibility model.Consumers that opt into
RN_STRICT_APInow get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it withRN_ALLOW_FRAMEWORKS; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D118440328