Skip to content

Cover react/renderer/imagemanager with Stable API guards #58307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −2
Open

Cover react/renderer/imagemanager with Stable API guards #58307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ react_native_android_selector(reactnativejni reactnativejni "")
target_link_libraries(react_renderer_imagemanager
folly_runtime
${mapbufferjni}
react_cxxstableapi
react_debug
react_renderer_core
react_renderer_debug
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <memory>

#include <react/renderer/core/ReactPrimitives.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/ImageRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/imagemanager/ImageResponse.h>
#include <react/renderer/imagemanager/ImageResponseObserver.h>
#include <react/renderer/imagemanager/ImageResponseObserverCoordinator.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <memory>

namespace facebook::react {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/imagemanager/ImageResponse.h>

namespace facebook::react {
Expand Down
2 changes: 2 additions & 0 deletions ...s/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/imagemanager/ImageResponse.h>
#include <react/renderer/imagemanager/ImageResponseObserver.h>
#include <react/utils/SharedFunction.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/ImageTelemetry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/core/ReactPrimitives.h>
#include <react/utils/Telemetry.h>

Expand Down
2 changes: 2 additions & 0 deletions ...n/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/imagemanager/ImageRequest.h>
#include <react/renderer/imagemanager/ImageRequestParams.h>
#include <react/utils/ContextContainer.h>
Expand Down
2 changes: 2 additions & 0 deletions ...t/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageRequestParams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <utility>

#include <react/renderer/graphics/Color.h>
Expand Down
2 changes: 2 additions & 0 deletions ...on/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/imagemanager/ImageRequestParams.h>
Expand Down
2 changes: 2 additions & 0 deletions ...react/renderer/imagemanager/platform/cxx/react/renderer/imagemanager/ImageRequestParams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/graphics/Float.h>

namespace facebook::react {
Expand Down
9 changes: 7 additions & 2 deletions ...ct-native/ReactCommon/react/renderer/imagemanager/platform/ios/React-ImageManager.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ Pod::Spec.new do |s|
header_search_paths = [
"\"$(PODS_TARGET_SRCROOT)/../../../\"",
"\"$(PODS_TARGET_SRCROOT)\"",
].join(" ")
]

if ENV['USE_FRAMEWORKS']
header_search_paths << "\"$(PODS_TARGET_SRCROOT)/../../../../..\"" # ReactCommon, for <react/cxxstableapi/...>
end

s.name = "React-ImageManager"
s.version = version
Expand All @@ -38,12 +42,13 @@ Pod::Spec.new do |s|

s.pod_target_xcconfig = {
"USE_HEADERMAP" => "NO",
"HEADER_SEARCH_PATHS" => header_search_paths,
"HEADER_SEARCH_PATHS" => header_search_paths.join(" "),
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
"DEFINES_MODULE" => "YES",
}

s.dependency "React-Core/Default"
s.dependency "React-cxxstableapi"

add_dependency(s, "React-Fabric")
add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
Expand Down
2 changes: 2 additions & 0 deletions ...react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/ImageRequestParams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/graphics/Float.h>

namespace facebook::react {
Expand Down
2 changes: 2 additions & 0 deletions ...on/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import "RCTImageManagerProtocol.h"
Expand Down
2 changes: 2 additions & 0 deletions .../renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImageManagerProtocol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <Foundation/Foundation.h>
#import <react/renderer/core/ReactPrimitives.h>
#import <react/renderer/imagemanager/ImageRequest.h>
Expand Down
2 changes: 2 additions & 0 deletions ...rer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import <React/RCTConvert.h>
Expand Down
2 changes: 2 additions & 0 deletions ...eact/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTSyncImageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import "RCTImageManagerProtocol.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <string>
#include <vector>

Expand Down
Loading