Repository navigation
Preserve native ScrollView insets during safe-area updates - #60021
Conversation
Summary: Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction. Changelog: [iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates Differential Revision: D132237950
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132237950. |
Visual regressionNo visual differences at android: no capture |
huntie
left a comment
There was a problem hiding this comment.
Didn't consider the refresh control(!). Assume there's internal screenshots on this diff to verify, but I trust you!
Shall I manage picking this to 0.89?
|
This pull request was successfully merged by @javache in cd42762 When will my fix make it into a release? | How to file a pick request? |
|
@huntie-bot Please pick to 0.88 and 0.89. Cite as a direct bugfix for #59194. |
Summary: Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction. Changelog: [iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates Differential Revision: D132237950 Pull Request resolved: #60021 (cherry picked from commit cd42762)
|
This pull request was successfully merged by @javache in f6ef1c4 When will my fix make it into a release? | How to file a pick request? |
|
This pull request was successfully merged by @javache in cd42762 When will my fix make it into a release? | How to file a pick request? |
Summary:
Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction.
Changelog:
[iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates
Differential Revision: D132237950