Skip to content

Preserve native ScrollView insets during safe-area updates - #60021

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
javache:export-D132237950
Nov 16, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
javache:export-D132237950

Conversation

@javache

@javache javache commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary:
Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction.

Changelog:
[iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates

Differential Revision: D132237950

Summary:
Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction.

Changelog:
[iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates

Differential Revision: D132237950
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@meta-codesync

meta-codesync Bot commented Nov 16, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132237950.

@github-actions

Copy link
Copy Markdown

Visual regression

No visual differences at 0f70674280a3.

android: no capture

@huntie huntie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't consider the refresh control(!). Assume there's internal screenshots on this diff to verify, but I trust you!

Shall I manage picking this to 0.89?

@meta-codesync
meta-codesync Bot merged commit cd42762 into react:main Nov 16, 2026
90 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @javache in cd42762

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 16, 2026
@javache
javache deleted the export-D132237950 branch November 16, 2026 15:57
@huntie

huntie commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

@huntie-bot Please pick to 0.88 and 0.89. Cite as a direct bugfix for #59194.

gabrieldonadel pushed a commit that referenced this pull request Nov 16, 2026
Summary:
Replace only the previous safe-area correction when the adjusted content inset changes, so insets added by native refresh controls and keyboard handling are not overwritten. Explicit base-content-inset updates still replace the requested inset, and changing the scroll axis or disabling content padding removes the previous correction.

Changelog:
[iOS][Fixed] - Preserve native refresh-control and keyboard insets during ScrollView safe-area updates

Differential Revision: D132237950

Pull Request resolved: #60021

(cherry picked from commit cd42762)
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @javache in f6ef1c4

When will my fix make it into a release? | How to file a pick request?

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @javache in cd42762

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants