Skip to content

Fix: Allow users to override usesCleartextTraffic in build.gradle manifestPlaceholders - #60133

Open
joshuaallgaier2-cmd wants to merge 2 commits into
react:mainfrom
joshuaallgaier2-cmd:main
Open

joshuaallgaier2-cmd wants to merge 2 commits into
react:mainfrom
joshuaallgaier2-cmd:main

Conversation

@joshuaallgaier2-cmd

Copy link
Copy Markdown

Description Fixes #60083 - The React Native Gradle plugin now respects user-defined usesCleartextTraffic values in build.gradle manifestPlaceholders instead of always overriding them. ### What changed In AgpConfiguratorUtils.kt, the configureBuildTypesForApp function now checks if usesCleartextTraffic is already set in manifestPlaceholders before setting the default value. ### why Previously, users could not customize usesCleartextTraffic in their build.gradle because the plugin always overwrote the value in the finalizeDsl callback, causing HTTP network requests to fail even when explicitly enabled. ### How tested Existing tests pass and manual test verifies user settings are now preserved. ### AI assistance Generated by DeepSeek Harness using qwen.qwen3-coder-next model to fix this issue. Fixes #60083

…ifestPlaceholders

Previously, the React Native Gradle plugin always overwrote the usesCleartextTraffic
manifest placeholder regardless of user configuration. This change checks if the
user has already set a value before overriding it with the default.

Fixes react#60083
@meta-cla

meta-cla Bot commented Nov 18, 2026

Copy link
Copy Markdown

Hi @joshuaallgaier2-cmd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions

Copy link
Copy Markdown

Warning

Missing Summary

Please add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Warning

Missing Test Plan

Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Caution

Missing Changelog

Please add a Changelog to your PR description. See Changelog format

Normalize paths to forward slashes before checking for snapshot directory
in the expected path, since path.join uses backslashes on Windows.

Fixes react#60026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

usesCleartextTraffic configuration issue in build.gradle

1 participant