Repository navigation
[DO NOT MERGE] Repro for #60140: recycled view keeps its custom container (iOS) - #60141
marvin-splitt wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi @marvin-splitt! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Reproducer only, not meant to be merged. It reproduces #60140: a recycled
RCTViewComponentViewkeeps_useCustomContainerViewfrom its previous owner (a view withoverflow: 'hidden'+boxShadow). On iOS, the new owner's children then end up in the wrong subview order, and the next index-based unmount assertsAttempt to unmount a view which has a different index.RNTesterPlayground.jsnow holds a four-tap screen:Viewwithoverflow: 'hidden'+boxShadow, so its native view goes to the recycle pool.View(collapsable={false},borderTopWidth) with two absolutely positioned children. It dequeues the recycled view and mounts the children through the stale container.key). It lands behind the first one: the green square is hidden under the red box.Changelog:
[INTERNAL] [ADDED] - Playground reproducer for #60140
Test Plan:
I ran the same component (same styles and steps) as a screen in an Expo SDK 58 dev client on RN 0.88.1 (prebuilt core), iOS 27.0 simulator, debug:
NSInternalInconsistencyException: Attempt to unmount a view which has a different index. 2 of 2 runs.boxShadowremoved from the first view: all four steps render correctly, no assertion.I haven't run it in RNTester on main. Reading the code, main still lacks the recycle reset; debaf42 (#59628) doesn't change where the children end up.
🤖 Generated with Claude Code