Skip to content

[CI] Reuse iOS template app builds across E2E retries - #60143

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
cipolleschi/ci-reuse-ios-template-builds
Nov 19, 2026
Merged

meta-codesync[bot] merged 1 commit into
mainfrom
cipolleschi/ci-reuse-ios-template-builds

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

An iOS template-app E2E retry currently rebuilds Debug and Release and reruns both configurations. Separate compilation from testing so test retries download the original successful apps, select only unsuccessful configurations, and resume Maestro flows that have not passed.

Builds and tests retain up to three attempts. Successful build configurations are carried forward while unsuccessful builds retry independently. Configuration-specific results prevent one passing matrix leg from overwriting another failure; missing results remain failures. Flow state is scoped to the configuration and GitHub run attempt, and malformed state is discarded before rerunning flows. Cancellation prevents further retries, and the final report fails when either configuration has not passed.

This PR targets main and preserves its existing runner and simulator configuration, including the arm64 executable check in the extracted build workflow.

Changelog:

[INTERNAL] [CHANGED] - Reuse iOS template app builds and completed flows across CI retries.

Test Plan:

  • Passed: yarn test .github/workflow-scripts/__tests__/template-app-ci-state-test.js .github/workflow-scripts/__tests__/maestro-ios-test.js .github/workflow-scripts/__tests__/report-test-results-test.js --runInBand — 3 suites, 64 tests.
  • Passed: yarn eslint --no-ignore --max-warnings 0 .github/workflow-scripts/template-app-ci-state.js .github/workflow-scripts/__tests__/template-app-ci-state-test.js.
  • Passed: yarn prettier --check .github/workflows/test-all.yml .github/workflows/build-ios-templateapp.yml .github/workflows/e2e-ios-templateapp.yml .github/workflow-scripts/template-app-ci-state.js .github/workflow-scripts/__tests__/template-app-ci-state-test.js.
  • Passed: /tmp/react-native-ci-tools/actionlint -shellcheck='' -ignore 'label "[48]-core-ubuntu" is unknown' -ignore 'description is required in metadata' .github/workflows/test-all.yml .github/workflows/build-ios-templateapp.yml .github/workflows/e2e-ios-templateapp.yml (actionlint 1.7.12; existing custom-label/action-description warnings excluded).
  • Passed: git diff --check.
  • Tests cover partial configuration success, lost outputs, exhausted retries, cancelled/skipped jobs, missing/corrupt flow state, and retaining completed flows.
  • Earlier hosted validation of the retry orchestration passed both template builds, both E2E jobs and both report jobs in Test All run 44519717859. Both reports retained separate passing Debug/Release results; all four unnecessary build/test retry calls were skipped.
  • Downloaded both hosted per-flow state artifacts: the expected start.yml flow passed on attempt 1 in both configurations. prepareTestState verified both files as complete, and both original app artifacts remain available. Failed-lane recovery was tested locally; no failures were deliberately injected into hosted CI.
  • Local checks above were rerun after rebasing onto main. This version preserves main's macos-26 template build/test runners and iPhone 17 Pro / iOS 26.2 simulator selection, and moves the arm64 executable check intact into the extracted build workflow. Hosted checks on the rebased head are pending.
  • The earlier full CI run had Ubuntu package-download timeouts in the unchanged Fantom and ReactCommon C++ setup jobs. They occur before compilation; successful CI checks are still needed before merge.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2026
@cipolleschi
cipolleschi force-pushed the cipolleschi/ci-reuse-ios-template-builds branch 2 times, most recently from 8776db7 to a47168a Compare November 19, 2026 13:23
@cipolleschi
cipolleschi changed the base branch from cipolleschi/ci-standard-macos-runners to main November 19, 2026 13:24
@cipolleschi
cipolleschi marked this pull request as ready for review November 19, 2026 13:24
@cipolleschi
cipolleschi force-pushed the cipolleschi/ci-reuse-ios-template-builds branch from a47168a to 97baecd Compare November 19, 2026 13:26
@cipolleschi
cipolleschi force-pushed the cipolleschi/ci-reuse-ios-template-builds branch from 97baecd to 4883476 Compare November 19, 2026 14:34
@meta-codesync

meta-codesync Bot commented Nov 19, 2026

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D133221246.

@javache javache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
meta-codesync Bot merged commit 3113e81 into main Nov 19, 2026
89 of 93 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 3113e81

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants