Repository navigation
[CI] Reuse iOS template app builds across E2E retries - #60143
Merged
meta-codesync[bot] merged 1 commit intoNov 19, 2026
Merged
Conversation
cipolleschi
force-pushed
the
cipolleschi/ci-reuse-ios-template-builds
branch
2 times, most recently
from
November 19, 2026 13:23
8776db7 to
a47168a
Compare
cipolleschi
changed the base branch from
cipolleschi/ci-standard-macos-runners
to
main
November 19, 2026 13:24
cipolleschi
marked this pull request as ready for review
November 19, 2026 13:24
cipolleschi
force-pushed
the
cipolleschi/ci-reuse-ios-template-builds
branch
from
November 19, 2026 13:26
a47168a to
97baecd
Compare
cipolleschi
force-pushed
the
cipolleschi/ci-reuse-ios-template-builds
branch
from
November 19, 2026 14:34
97baecd to
4883476
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D133221246. |
javache
approved these changes
Nov 19, 2026
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @cipolleschi in 3113e81 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
An iOS template-app E2E retry currently rebuilds Debug and Release and reruns both configurations. Separate compilation from testing so test retries download the original successful apps, select only unsuccessful configurations, and resume Maestro flows that have not passed.
Builds and tests retain up to three attempts. Successful build configurations are carried forward while unsuccessful builds retry independently. Configuration-specific results prevent one passing matrix leg from overwriting another failure; missing results remain failures. Flow state is scoped to the configuration and GitHub run attempt, and malformed state is discarded before rerunning flows. Cancellation prevents further retries, and the final report fails when either configuration has not passed.
This PR targets main and preserves its existing runner and simulator configuration, including the arm64 executable check in the extracted build workflow.
Changelog:
[INTERNAL] [CHANGED] - Reuse iOS template app builds and completed flows across CI retries.
Test Plan:
yarn test .github/workflow-scripts/__tests__/template-app-ci-state-test.js .github/workflow-scripts/__tests__/maestro-ios-test.js .github/workflow-scripts/__tests__/report-test-results-test.js --runInBand— 3 suites, 64 tests.yarn eslint --no-ignore --max-warnings 0 .github/workflow-scripts/template-app-ci-state.js .github/workflow-scripts/__tests__/template-app-ci-state-test.js.yarn prettier --check .github/workflows/test-all.yml .github/workflows/build-ios-templateapp.yml .github/workflows/e2e-ios-templateapp.yml .github/workflow-scripts/template-app-ci-state.js .github/workflow-scripts/__tests__/template-app-ci-state-test.js./tmp/react-native-ci-tools/actionlint -shellcheck='' -ignore 'label "[48]-core-ubuntu" is unknown' -ignore 'description is required in metadata' .github/workflows/test-all.yml .github/workflows/build-ios-templateapp.yml .github/workflows/e2e-ios-templateapp.yml(actionlint 1.7.12; existing custom-label/action-description warnings excluded).git diff --check.start.ymlflow passed on attempt 1 in both configurations.prepareTestStateverified both files as complete, and both original app artifacts remain available. Failed-lane recovery was tested locally; no failures were deliberately injected into hosted CI.macos-26template build/test runners and iPhone 17 Pro / iOS 26.2 simulator selection, and moves the arm64 executable check intact into the extracted build workflow. Hosted checks on the rebased head are pending.