Repository navigation
Type mutable style and event registry builders - #60144
Merged
Merged
Conversation
Summary: ## Context React Native implementation type improvements use `satisfies` and signed-readonly mapped types. The open-source Flow checker needs an explicit opt-in before source files can adopt these features. ## Changes - Enable `experimental.tslib_syntax=true` in the open-source Flow configuration. - Keep the syntax opt-in separate from the implementation refactors that use it. Changelog: [Internal] Differential Revision: D133191436
Summary: ## Context Style splitting builds fresh objects, while the listener registry allocates and deletes event slots. Using readonly API types for these mutable implementation objects requires unnecessary write suppressions. The listener registry is also sparse: event keys need not exist before registration. ## Changes - Derive a mutable view-style builder with a mapped type that removes readonly, keeping readonly style inputs and returned API types. - Make listener-registry slots mutable and optional while preserving readonly event argument tuples and registrations. - Remove six obsolete suppressions for readonly writes and style-builder initialization. - Preserve runtime code, null-prototype registry storage, and existing dynamic-key suppressions. Flow configurations that check React Native implementation source need `experimental.tslib_syntax=true` for signed-readonly mapped types. The preceding configuration-only change provides that opt-in for React Native's OSS validation. Changelog: [Internal] Differential Revision: D132934090
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132934090. |
javache
approved these changes
Nov 19, 2026
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @rubennorte in 1a44dcf When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Style splitting builds fresh objects, while the listener registry allocates and deletes event slots. Using readonly API types for these mutable implementation objects requires unnecessary write suppressions. The listener registry is also sparse: event keys need not exist before registration.
Changes
Flow configurations that check React Native implementation source need
experimental.tslib_syntax=truefor signed-readonly mapped types. The preceding configuration-only change provides that opt-in for React Native's OSS validation.Changelog: [Internal]
Differential Revision: D132934090