Repository navigation
Conversation
huntie
marked this pull request as ready for review
November 19, 2026 15:22
Collaborator
Author
|
@huntie-bot Pick to 0.89 once merged. |
1 of 3 tasks
javache
approved these changes
Nov 20, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D133462554. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🚨 Critical fix for the
StatusBar.getVerticalBarEdgeIOS()feature, as the native side of this is currently compiled out due to the version of Xcode we build with.setup-xcodedefault onmacos-15, so its iOS 18.5 SDK compiles out everything gated on__IPHONE_OS_VERSION_MAX_ALLOWED >= 270100.StatusBar.getVerticalBarEdgeIOS()anduseVerticalBarEdgeIOS()always returnnullon iPhone Duo, while source builds report the edge value.Changes
prebuild-ios-corejobs on thexcode-27runner image and pin Xcode 27.2. Editing the workflow also changes the cache keys, so no slice built with the old SDK is reused.Note
xcode-27is still a GitHub preview image, which can queue longer thanmacos-15.Also potentially affected
Other code gated on an SDK newer than iOS 18.5, compiled out of the 0.89.0-rc.2 prebuilt core:
>= 270000RCTStatusBarManager.mm(RCTAppLevelStatusBarIsNoOp)NO, so the warning forUIViewControllerBasedStatusBarAppearance = NOnever fires in apps built with the iOS 27 SDK, where the app-level setters do nothing.>= 260000RCTEnhancedScrollView.mm(setInverted:)>= 260100RCTAccessibilityManager.mm(Show Borders)UIAccessibilityButtonShapesEnabledon iOS 26.1+ instead ofAXShowBordersEnabled.Changelog: [Internal]
Changelog (0.89):
[iOS][Fixed] - StatusBar:
getVerticalBarEdgeIOS()anduseVerticalBarEdgeIOS()report the vertical bar edge when using the prebuilt React Native coreTest Plan
Checked in an app on 0.89.0-rc.2 on the iPhone Duo simulator (iOS 27.2):
React.frameworkreportssdk 18.5(vtool -show-build) and contains noverticalBarEdgeselector, andStatusBar.getVerticalBarEdgeIOS()returnsnullwhile the key window's trait collection hasverticalBarEdgeset to trailing.The workflow change itself runs only in CI.